vcr icon indicating copy to clipboard operation
vcr copied to clipboard

check if vcr works with tinytest and testit

Open sckott opened this issue 5 years ago • 15 comments

  • [ ] tinytest
  • [ ] testit

sckott avatar Mar 04 '20 00:03 sckott

started on this on branch https://github.com/ropensci/vcr/compare/tinytest

sckott avatar Mar 04 '20 00:03 sckott

did it work?

maelle avatar Sep 21 '20 12:09 maelle

don't remember, so long ago now. i don't think it worked, OR I didn't fully test it yet, not sure which one

sckott avatar Sep 21 '20 15:09 sckott

Ok

maelle avatar Sep 21 '20 15:09 maelle

tinytest stores/expects test_*.R files in inst/tinytest, rather than tests/tinytest, so at the very least we'd have to adapt vcr_test_path() to that (assuming that tinytest also sets the working dir to inst/tinytest during tests).

dpprdan avatar Jan 03 '22 19:01 dpprdan

thanks @dpprdan - if anyone has time to check if vcr works with these two pkgs ...

sckott avatar Jan 04 '22 16:01 sckott

@sckott Be happy to work on tinytest:: testing. Also have worked with httr:: and httr2:: Will fork clone and use the branch already setup https://github.com/ropensci/vcr/compare/tinytest

jim

jimrothstein avatar Nov 07 '22 00:11 jimrothstein

thanks @jimrothstein ! sounds great

sckott avatar Nov 07 '22 00:11 sckott

@sckott working just locally, writing **tinytest** functions roughly equivalent to **testthat** functions ( so far for test_Filesystem.Randtest_Cassette.R`) When I have couple more R files tested will try again to push.

figured it out! ~~Not quite sure how to write separate package with just tinytest and library(vcr). Don't the test files need to included in source package?~~

jimrothstein avatar Nov 11 '22 10:11 jimrothstein

great!

sckott avatar Nov 14 '22 19:11 sckott

@sckott Quick update: tinytests are coming along, but reading through some of the source code, R6, configuration takes some time.

jimrothstein avatar Nov 17 '22 08:11 jimrothstein

ok, thanks for the update

sckott avatar Nov 17 '22 23:11 sckott

@sckott Update. This is rough, rough, very rough. WIP. But tinytests are beginning to work and various pieces make more sense to me. Will get faster. Example: https://github.com/jimrothstein/test_vcr/blob/master/inst/tinytest/test_configure.R

jimrothstein avatar Nov 21 '22 09:11 jimrothstein

@jimrothstein sounds good

sckott avatar Nov 21 '22 16:11 sckott

@sckott Bunch of tinytests seems to be working. Before I get too much further, I like to get my package {testVCR} into form you can review. (There are still loose ends or temp files that need cleanup. And, of course, many more tests to write.)

https://github.com/jimrothstein/test_vcr/tree/master/inst/tinytest

@sckott - just another ping, to see if I'm heading in right direction.

jimrothstein avatar Nov 23 '22 09:11 jimrothstein