traits
traits copied to clipboard
NCBI changed 'country' qualifier to 'geo_loc_name' in `ncbi_byid()`
As per link below, NCBI have changed the 'country' qualifier to 'geo_loc_name', which mean the ncbi_byid() function no longer parses the XML and produces a 'country' field.
https://ncbiinsights.ncbi.nlm.nih.gov/2023/12/14/update-genbank-qualifier/
It's simple fix and I've issued a pull request.
Code to test:
# load
library("renv")
library("dplyr")
# test traits at current commit
renv::install("ropensci/traits@ee58d04")
traits::ncbi_byid(ids="MT523282.1") |> dplyr::distinct(country) |> print()
# result is 'NA'
# text fix on fork
# restart R
renv::install("boopsboops/traits@ccd098a")
traits::ncbi_byid(ids="MT523282.1") |> dplyr::distinct(country) |> print()
# result is 'Uganda: Kyambura river, mouth, Kazinga Channel' (expected result)
@boopsboops thank you for reporting this and submitting a PR! I've merged your PR and will push to CRAN.