tidyqpcr
tidyqpcr copied to clipboard
Replace superseded "do" function calls
From #85 Flic's code review
In calculate_deltadeltacq_bytargetid(), dplyr::do() is SUPERCEDED, perhaps use alternatives suggested in dplyr docs (summarise(), nest_by() and across()) : https://dplyr.tidyverse.org/reference/do.html https://github.com/ewallace/tidyqpcr/blob/master/R/calculate_deltacq.R#L142
Oh dear, I didn’t realise do() was superseded! That is a very nice function.
Low priority though, if it works?
I have recently tried to look at this in other situations, and even though do() is superseded I still find it more intuitive in some situations.
Update: dplyr::summarise now allows return of data frames. That means that we would be able to replace do calls with summarise calls, and update dplyr dependency to v1.0.0 or later.
Hello! Is this issue still relevant?:)
Hello @MichalLauer - yes this issue is still relevant. I'm just reviewing and updating tidyqpcr. Currently do() still works, and is not generating warnings, but, it's still superseded.
I'm flagging as "help wanted".