tabulapdf icon indicating copy to clipboard operation
tabulapdf copied to clipboard

Allows for multiple tables per page

Open SteveLane opened this issue 7 years ago • 5 comments

This edit allows for multiple tables per page to be read using list_matrices method. If there is only one table on a page, a matrix is returned, else a list of matrices are returned.

SteveLane avatar Dec 21 '16 22:12 SteveLane

@leeper I haven't added any tests for this - it's just the bare change. I can add tests, or anything else you'd like - just let me know.

SteveLane avatar Dec 21 '16 22:12 SteveLane

Of course, list_characters and list_data_frames needed updating as well, sorry for the extra commits. Also - whilst testing, the non-western table check failed. The extract_tables function actually pulls in two tables. Not sure if it's the package bug, or a tabula-java bug - I'll open an issue anyway (Issue #32).

SteveLane avatar Dec 22 '16 00:12 SteveLane

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b2e7791). Click here to learn what that means. The diff coverage is 95.12%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #31   +/-   ##
=========================================
  Coverage          ?   57.82%           
=========================================
  Files             ?       12           
  Lines             ?      569           
  Branches          ?        0           
=========================================
  Hits              ?      329           
  Misses            ?      240           
  Partials          ?        0
Impacted Files Coverage Δ
R/output.R 97.11% <95.12%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b2e7791...88df806. Read the comment docs.

codecov-io avatar Dec 22 '16 01:12 codecov-io

Sorry, @SteveLane, for the delay on this. I will try to get to it as soon as I can.

leeper avatar Jan 15 '17 09:01 leeper

let me test how these changes go with tabula 1.0.5

pachadotdev avatar Apr 30 '24 23:04 pachadotdev