suppdata icon indicating copy to clipboard operation
suppdata copied to clipboard

Fixes for CRAN

Open willpearse opened this issue 5 years ago • 1 comments

The package's checks on CRAN failed because their test server was misconfigured (see https://cran.r-project.org/web/checks/check_results_suppdata.html for the log) and so CRAN have done a review. They are concerned that the package doesn't follow CRAN's guidelines, specifically:

Packages which use Internet resources should fail gracefully with an informative message if the resource is not available or has changed (and not give a check warning nor error).

...which is fair enough, and so we should fix this. The problem is they are threatening to pull the package by the 1st of November if these changes aren't made.Does anyone (@sckott or @nuest ?) have the bandwidth right now to fix this? I ask because I am a bit busy right now. I think the necessary steps would be:

  • [ ] Insert tryCatch statements into the download wrappers in utils.R
  • [ ] Make sure none of the journal functions in downloads.R use other download methods (and if they do, wrapper those)
  • [ ] Insert \dontrun comments around everything in every one of the help files. I realise we had to remove those before for CRAN, but now it seems they want them back in (or at least that's how I read the parenthetical in the above quote)
  • [ ] Ensure all the tests are flagged to not run on CRAN as well
  • [ ] (optional) I have a branch (winzip) that would be nice to merge in, as it helps with a weird edge case of zip files on Windows.

Absolutely no worries whatsoever if no one has the time to do this; if that's the case, I'll get to this later in the week. I'm asking in the vein of "if you don't ask, you don't get". This is a very difficult time for everyone right now, and I really don't want to add to anyone's stress - please don't offer to help unless it really, truly would be easy for you to help as I can do this if necessary. (I should add that I have already asked for extra time from CRAN because of the pandemic and been ignored).

willpearse avatar Oct 27 '20 19:10 willpearse

I don't have time right now - even if it's archived, you can still submit whenever you have time

sckott avatar Oct 28 '20 16:10 sckott