skimr icon indicating copy to clipboard operation
skimr copied to clipboard

Published 20 hours ago • verified publisher icon ropensci

Issues with 4.2

Open elinw opened this issue 2 years ago • 1 comments

So it looks like the switch from a warning to error for if() of objects of length 1 revealed that we had a hidden warning. This becoming an error then led to cascading other problems. For reasons I'm not sure of there was also a problem with finding reassign_skim_attributes. All this is why the original issue of pkgdown not building arose.

elinw avatar Apr 26 '22 12:04 elinw

I just checked this against the current develop branch (after merging in all changes for the next version)

devtools::check(env_vars = c("_R_CHECK_LENGTH_1_CONDITION_" = "true"))

Once the fix for #700 is in, can you let me know if this is still an issue? Thanks!

michaelquinn32 avatar Apr 28 '22 01:04 michaelquinn32

I think we're good!

elinw avatar Dec 25 '22 19:12 elinw