rrlite icon indicating copy to clipboard operation
rrlite copied to clipboard

Prepare for rOpenSci onboarding

Open richfitz opened this issue 10 years ago • 4 comments

See https://github.com/ropensci/onboarding/issues/6, courtesy of @stewid

  • [x] Change DESCRIPTION:Title to title case
  • [x] List author(s) of included software.
  • [x] List copyright(s) of included software.
  • [ ] I was unable to run make check and make test. I'll open an issue with the output at https://github.com/richfitz/rrlite.
  • [x] Add argument check in e.g. https://github.com/richfitz/rrlite/blob/b390ba0afb5f1613572ba4ce3d5d733987edd0bd/src/rrlite.c#L35 to protect against unexpected values of filename (NA, NULL)
  • [x] Add a rOpenSci footer.
  • [ ] Add an appropriate entry into ropensci.org/packages/index.html

richfitz avatar Apr 10 '15 22:04 richfitz

Output from make test

Rscript --no-init-file -e 'library(methods); devtools::test()'
Testing rrlite
df_to_rows : ....
help : ............
hirlite : ...1.2..........
Objects : ........
rlite + RcppRedis : ...........
rdb : ........
rlite_context : ..........................345.678.9ab.........cd..e.................fg......


1. Failure(@test-hirlite.R#8): basic use ---------------------------------------
r$del("foo") not equal to 1L
Mean relative difference: 1

2. Failure(@test-hirlite.R#10): basic use --------------------------------------
r$keys("*") not equal to list()
Length mismatch: comparison on first 0 components

3. Failure(@test-rlite-context.R#101): db:rename -------------------------------
con$read() not equal to "OK"
Modes: character, NULL
Lengths: 1, 0
target is character, current is NULL

4. Failure(@test-rlite-context.R#104): db:rename -------------------------------
con$read() isn't null

5. Failure(@test-rlite-context.R#107): db:rename -------------------------------
con$read() not equal to "mydata"
Modes: character, NULL
Lengths: 1, 0
target is character, current is NULL

6. Failure(@test-rlite-context.R#117): db:renamenx -----------------------------
con$read() is not identical to 1L. Differences:
Modes: numeric, NULL
Lengths: 1, 0
target is numeric, current is NULL

7. Failure(@test-rlite-context.R#120): db:renamenx -----------------------------
con$read() isn't null

8. Failure(@test-rlite-context.R#123): db:renamenx -----------------------------
con$read() not equal to "mydata"
Modes: character, NULL
Lengths: 1, 0
target is character, current is NULL

9. Failure(@test-rlite-context.R#129): db:renamenx -----------------------------
con$read() is not identical to 0L. Differences:
Modes: numeric, NULL
Lengths: 1, 0
target is numeric, current is NULL

a. Failure(@test-rlite-context.R#132): db:renamenx -----------------------------
con$read() not equal to "mydata2"
1 string mismatches:
x[1]: "mydata2"
y[1]: "mydata"



b. Failure(@test-rlite-context.R#135): db:renamenx -----------------------------
con$read() not equal to "mydata"
Modes: character, NULL
Lengths: 1, 0
target is character, current is NULL

c. Failure(@test-rlite-context.R#198): db:move ---------------------------------
con$read() not equal to 1L
Modes: numeric, NULL
Lengths: 1, 0
target is numeric, current is NULL

d. Failure(@test-rlite-context.R#201): db:move ---------------------------------
con$read() not equal to 0L
Mean absolute difference: 1

e. Failure(@test-rlite-context.R#210): db:move ---------------------------------
con$read() not equal to 0L
Modes: numeric, NULL
Lengths: 1, 0
target is numeric, current is NULL

f. Failure(@test-rlite-context.R#258): db:flushdb ------------------------------
con$run("flushdb") not equal to "OK"
Modes: character, NULL
Lengths: 1, 0
target is character, current is NULL

g. Failure(@test-rlite-context.R#259): db:flushdb ------------------------------
con$run("dbsize") is not identical to 0L. Differences:
Mean absolute difference: 1

stewid avatar Apr 10 '15 22:04 stewid

Output from make check

make check
R CMD build .
* checking for file ‘./DESCRIPTION’ ... OK
* preparing ‘rrlite’:
* checking DESCRIPTION meta-information ... OK
* cleaning src
* running ‘cleanup’
* installing the package to build vignettes
* creating vignettes ... ERROR
Quitting from lines 151-155 (rrlite.Rmd)
Error: processing vignette 'rrlite.Rmd' failed with diagnostics:
read error
Execution halted

stewid avatar Apr 10 '15 22:04 stewid

My sessionInfo

R version 3.1.3 (2015-03-09)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 14.04.2 LTS

locale:
 [1] LC_CTYPE=sv_SE.UTF-8       LC_NUMERIC=C
 [3] LC_TIME=sv_SE.UTF-8        LC_COLLATE=sv_SE.UTF-8
 [5] LC_MONETARY=sv_SE.UTF-8    LC_MESSAGES=sv_SE.UTF-8
 [7] LC_PAPER=sv_SE.UTF-8       LC_NAME=C
 [9] LC_ADDRESS=C               LC_TELEPHONE=C
[11] LC_MEASUREMENT=sv_SE.UTF-8 LC_IDENTIFICATION=C

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] rrlite_0.1.0

loaded via a namespace (and not attached):
[1] R6_2.0.1    Rcpp_0.11.5

stewid avatar Apr 10 '15 22:04 stewid

OK, pretty much done aside from the error you saw which I don't see on OSX, travis or on a docker container (based off r-base).

richfitz avatar Apr 13 '15 02:04 richfitz