robotstxt icon indicating copy to clipboard operation
robotstxt copied to clipboard

CRAN: Error(s) in re-building vignettes

Open petermeissner opened this issue 2 years ago • 4 comments

Dear maintainer,

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_robotstxt.html.

Please correct before 2023-03-15 to safely retain your package on CRAN.

Best, -k

... relevant error lines:

checking re-building of vignette outputs ... [4s/10s] ERROR
Error(s) in re-building vignettes:
  ...
--- re-building ‘using_robotstxt.Rmd’ using rmarkdown
Quitting from lines 126-131 (using_robotstxt.Rmd)
Error: processing vignette ‘using_robotstxt.Rmd’ failed with diagnostics:
Timeout was reached: [wikipedia.org] Failed to connect to wikipedia.org port 80 after 5255 ms: Couldn't connect to server
--- failed re-building ‘using_robotstxt.Rmd’

SUMMARY: processing the following file failed:
  ‘using_robotstxt.Rmd’

Error: Vignette re-building failed.
Execution halted

petermeissner avatar Mar 01 '23 17:03 petermeissner

@petermeissner building the vignettes works okay localy. Can this be just a random network failure? What can we do here?

pedrobtz avatar Mar 01 '23 20:03 pedrobtz

I found it best to disable external network checks in CRAN test for literally anything I have left on CRAN. It's just not worth the trouble IMO.

On Wed, Mar 1, 2023 at 3:07 PM Pedro Z @.***> wrote:

@petermeissner https://github.com/petermeissner building the vignettes works okay localy. Can this be just a random network failure? What can we do here?

— Reply to this email directly, view it on GitHub https://github.com/ropensci/robotstxt/issues/69#issuecomment-1450781090, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD4PNTXOMUW3YZUBBYFGWDWZ6UBVANCNFSM6AAAAAAVMKSNHY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

hrbrmstr avatar Mar 01 '23 20:03 hrbrmstr

Yes, I could reproduce the error yesterday evening, now it works - I assume there was a hickup on wikipedia.org/robots.txt.

Going with @hrbrmstr approach would be best, I think: Make the vignette not use anything that involves real network calls. @pedrobtz maybe you have a clever idea for how to mock/handle this.

petermeissner avatar Mar 02 '23 08:03 petermeissner

Would it be possible to submit already the vignettes/using_robotstxt.html or it needs to be built on CRAN side?

pedrobtz avatar Mar 02 '23 08:03 pedrobtz

#70

petermeissner avatar Aug 15 '24 07:08 petermeissner