rerddap icon indicating copy to clipboard operation
rerddap copied to clipboard

Incomplete example in get started vignette for fun global_search()

Open salvafern opened this issue 1 year ago • 3 comments

Hello there :wave:

I just noticed there is an incomplete example in the get started vignette:

global_search(query, server_list, which_service)
#> Error in check_arg(query, "character"): object 'query' not found

https://docs.ropensci.org/rerddap/reference/global_search.html

But I also saw this error message is hard coded in https://github.com/ropensci/rerddap/blob/55960549c639f053d29ac55350db65c059b720c9/vignettes/rerddap.Rmd#L99 so not sure if this is intentional.

In any case I made a quick fix (https://github.com/salvafern/rerddap/commit/8b6db96bf42202439f87408d6a6daeae9c295f8f), happy to PR if you agree.

Thanks for this great package! Salva

salvafern avatar Jun 23 '23 12:06 salvafern