jstor icon indicating copy to clipboard operation
jstor copied to clipboard

Failure with tibble 3.1.3 reported by CRAN

Open krlmlr opened this issue 2 years ago • 0 comments

I checked locally, can't replicate.

Package: jstor
Check: tests
New result: ERROR
   Running ‘testthat.R’ [10s/20s]
 Running the tests in ‘tests/testthat.R’ failed.
 Complete output:
library(testthat)
library(jstor)

test_check("jstor")
   ══ Skipped tests ═══════════════════════════════════════════════════════════════
   • Downloading was disabled (1)
   • This test is stupid, should be improved. It depends on the console width
          which is not a good idea. (1)
   • empty test (2)

   ══ Failed tests ════════════════════════════════════════════════════════════════
   ── Failure (test-writing-to-file.R:24:3): writing correct results to file works ──
   read_csv("testfiles/correct_meta_data.csv", col_names = TRUE) not identical to read_csv(file.path(temp_dir, "/meta_data-1.csv"), col_names = TRUE).
   Objects equal but not identical
   ── Failure (test-writing-to-file.R:38:3): writing to file in parallel works ────
   read_csv("testfiles/correct_meta_data.csv", col_names = TRUE) not identical to read_csv(file.path(temp_dir, "/meta_data-1.csv"), col_names = TRUE).
   Objects equal but not identical
   ── Failure (test-writing-to-file.R:51:3): not writing column names works ───────
   read_csv("testfiles/correct_meta_data_wo_cols.csv", col_names = FALSE) not identical to read_csv(file.path(temp_dir, "/meta_data-1.csv"), col_names = FALSE).
   Objects equal but not identical
   ── Failure (test-writing-to-file.R:80:3): writing error messages to file works ──
   `res` not identical to `correct_res`.
   Objects equal but not identical
   ── Failure (test-writing-to-file.R:91:3): import wrapper works with column names ──
   read_csv("testfiles/correct_meta_data.csv", col_names = TRUE) not identical to read_csv(file.path(temp_dir, "/meta_data-1.csv"), col_names = TRUE).
   Objects equal but not identical
   ── Failure (test-writing-to-file.R:104:3): import wrapper works without column names ──
   read_csv("testfiles/correct_meta_data_wo_cols.csv", col_names = FALSE) not identical to read_csv(file.path(temp_dir, "/meta_data-1.csv"), col_names = FALSE).
   Objects equal but not identical
   ── Failure (test-writing-to-file.R:117:3): files_per_batch works ───────────────
   read_csv("testfiles/correct_meta_data_wo_cols.csv", col_names = FALSE) not identical to read_csv(file.path(temp_dir, "/meta_data-1.csv"), col_names = FALSE).
   Objects equal but not identical
   ── Failure (test-zip.R:51:3): importing from zip works ─────────────────────────
   read_csv(file.path("testfiles", expected_file)) not identical to read_csv(file.path(test_dir, expected_file)).
   Objects equal but not identical
   Backtrace:
       █
    1. ├─expected_files %>% purrr::map(test_expected_zip) test-zip.R:51:2
    2. └─purrr::map(., test_expected_zip)
    3.   └─jstor:::.f(.x[[i]], ...)
    4.     └─testthat::expect_identical(...) test-zip.R:48:4
   ── Failure (test-zip.R:51:3): importing from zip works ─────────────────────────
   read_csv(file.path("testfiles", expected_file)) not identical to read_csv(file.path(test_dir, expected_file)).
   Objects equal but not identical
   Backtrace:
       █
    1. ├─expected_files %>% purrr::map(test_expected_zip) test-zip.R:51:2
    2. └─purrr::map(., test_expected_zip)
    3.   └─jstor:::.f(.x[[i]], ...)
    4.     └─testthat::expect_identical(...) test-zip.R:48:4
   ── Failure (test-zip.R:51:3): importing from zip works ─────────────────────────
   read_csv(file.path("testfiles", expected_file)) not identical to read_csv(file.path(test_dir, expected_file)).
   Objects equal but not identical
   Backtrace:
       █
    1. ├─expected_files %>% purrr::map(test_expected_zip) test-zip.R:51:2
    2. └─purrr::map(., test_expected_zip)
    3.   └─jstor:::.f(.x[[i]], ...)
    4.     └─testthat::expect_identical(...) test-zip.R:48:4
   ── Failure (test-zip.R:51:3): importing from zip works ─────────────────────────
   read_csv(file.path("testfiles", expected_file)) not identical to read_csv(file.path(test_dir, expected_file)).
   Objects equal but not identical
   Backtrace:
       █
    1. ├─expected_files %>% purrr::map(test_expected_zip) test-zip.R:51:2
    2. └─purrr::map(., test_expected_zip)
    3.   └─jstor:::.f(.x[[i]], ...)
    4.     └─testthat::expect_identical(...) test-zip.R:48:4

   [ FAIL 11 | WARN 1 | SKIP 4 | PASS 242 ]
   Error: Test failures
   Execution halted

krlmlr avatar Jul 23 '21 07:07 krlmlr