rotemplate icon indicating copy to clipboard operation
rotemplate copied to clipboard

New pkgdown issues

Open jeroen opened this issue 1 year ago • 46 comments

A few test pages:

  • https://docs.ropensci.org/magick/ (search box is gone?)
  • https://docs.ropensci.org/jagstargets/
  • https://docs.ropensci.org/dynamite/articles/dynamite_priors.html (math seems ok??)
  • https://docs.ropensci.org/unrtf/ (looks ok?)
  • https://docs.ropensci.org/mctq/ (no search box, alignment of navbar seems weird?)

Also there is an issue with the favicons. In the previous version we used common favicons on docs.ropensci.org e.g.

  • https://docs.ropensci.org/apple-touch-icon.png
  • https://docs.ropensci.org/favicon-32x32.png

And so on. However the new page has favicons in the pkgdown site, but those are missing:

Writing to: /tmp/Rtmpror1TN/unrtf
── Sitrep ──────────────────────────────────────────────────────────────────────
✔ URLs ok.
✖ Favicons not ok.
  Package logo is newer than favicons.
  Do you need to rerun `build_favicons()`?
✔ Open graph metadata ok.
✔ Articles metadata ok.
✔ Reference metadata ok.

jeroen avatar Jul 05 '24 10:07 jeroen

Regarding the search box disappearance, it's due to a fix in pkgdown https://github.com/r-lib/pkgdown/blob/main/NEWS.md#_pkgdownyaml

You can now choose where the search box is placed with the "search" navbar component. This has been documented for a very long time, but as far as I can tell, never worked (#2320). If you have made your own template with a custom navbar, you will need to remove the

with role="search" to avoid getting two search boxes.

The fix has to happen on the side of the packages as in https://github.com/ropensci/magick/pull/401, unless we want to add some sort of compatibility layer within rotemplate.

maelle avatar Jul 05 '24 12:07 maelle

https://github.com/ropensci/mctq/pull/33

maelle avatar Jul 05 '24 12:07 maelle

https://github.com/ropensci/jagstargets/pull/33

maelle avatar Jul 05 '24 12:07 maelle

reg https://docs.ropensci.org/dynamite/articles/dynamite_priors.html has math always been this ugly? it looks a tad off

maelle avatar Jul 05 '24 12:07 maelle

https://github.com/ropensci/drake/pull/1376

maelle avatar Jul 05 '24 13:07 maelle

https://github.com/ropensci/MtreeRing/pull/16

maelle avatar Jul 05 '24 13:07 maelle

https://github.com/ropensci/jstor/pull/90

maelle avatar Jul 05 '24 13:07 maelle

https://github.com/ropensci/osfr/commit/67315ad3cff5d153e21d462f554f877ff8d5bcd3 (committed to the default branch as the latest commit was two years ago)

maelle avatar Jul 05 '24 13:07 maelle

https://github.com/ropensci/spiro/pull/11

maelle avatar Jul 05 '24 13:07 maelle

https://github.com/ropensci/codemetar/commit/f05d72aeae75682a3c88ff976311fcfe118df29d

maelle avatar Jul 05 '24 13:07 maelle

https://github.com/ropensci/spatsoc/pull/63

maelle avatar Jul 05 '24 13:07 maelle

https://github.com/ropensci/tic/pull/338

maelle avatar Jul 05 '24 14:07 maelle

https://github.com/ropensci/NLMR/pull/109

maelle avatar Jul 05 '24 14:07 maelle

https://github.com/ropensci/phruta/issues/22

maelle avatar Jul 05 '24 14:07 maelle

https://github.com/ropensci/rfema/pull/14

maelle avatar Jul 05 '24 14:07 maelle

https://github.com/ropensci/terrainr/pull/71

maelle avatar Jul 05 '24 14:07 maelle

TODO

  • https://github.com/ropensci/workloopR/blob/d2122c751ffcc1690cb482e7f01b50845fef382a/_pkgdown.yml#L12
  • https://github.com/ropensci/stantargets/blob/9ffea0b03b8f8a6774b6e52d5bc8b181dcffe37b/_pkgdown.yml#L4
  • https://github.com/ropensci/gittargets/blob/013ed97c88c78d466edf458b54bcdde95d5061a0/_pkgdown.yml#L4
  • https://github.com/ropensci/mapscanner/blob/1a210ce77ad1b83a8baad29960d4c891e6b1fda8/_pkgdown.yml#L27
  • https://github.com/ropensci/tsbox/blob/ad278e22cdc532043e83c938b5aca318e20d2efe/_pkgdown.yml#L105
  • https://github.com/ropensci/tarchetypes/blob/dc552e9561721ea7d4f19154fd5aea5cce6bf54f/_pkgdown.yml#L4
  • https://github.com/ropensci/patentsview/blob/101468a68b8937fd0f2943b4c864816784dd0b64/_pkgdown.yml#L27
  • ...

maelle avatar Jul 05 '24 14:07 maelle

not breaking anyway: https://github.com/ropensci/workloopR/pull/3

maelle avatar Jul 17 '24 15:07 maelle

https://github.com/ropensci/stantargets/pull/66

maelle avatar Jul 17 '24 15:07 maelle

https://github.com/ropensci/gittargets/pull/17

maelle avatar Jul 17 '24 15:07 maelle

https://github.com/ropensci/mapscanner/pull/51

maelle avatar Jul 17 '24 15:07 maelle

https://github.com/ropensci/tsbox/pull/225

maelle avatar Jul 17 '24 15:07 maelle

https://github.com/ropensci/tarchetypes/pull/182

maelle avatar Jul 17 '24 15:07 maelle

https://github.com/ropensci/patentsview/pull/34

maelle avatar Jul 17 '24 15:07 maelle

https://github.com/ropensci/visdat/pull/168

maelle avatar Jul 17 '24 15:07 maelle

https://github.com/ropensci/googleLanguageR/pull/88

maelle avatar Jul 17 '24 15:07 maelle

https://github.com/ropensci/osmdata/pull/345

maelle avatar Jul 17 '24 15:07 maelle

https://github.com/ropensci/mapscanner/pull/52

maelle avatar Jul 17 '24 15:07 maelle

https://github.com/ropensci/git2rdata/pull/73

maelle avatar Jul 17 '24 16:07 maelle

https://github.com/ropensci/dbparser/pull/171

maelle avatar Jul 17 '24 16:07 maelle