lawn
lawn copied to clipboard
Linting changes: Allow user to set behavior of linting, Use geojsonlint?
@jhollist @ateucher
- In discussing the right hand rule, i noticed that our linting functionality in
lawn
always stops when the linter fails. Should we allow user to toggle this behavior to stop or simply warn when it fails? - should we depend on
geojsonlint
R pkg (which is now on cran)? instead of using the js librarygeojsonhint
- which is one of the options ingeojsonlint
R pkg (others are geojsonlint web API and geojson schema validation viais-my-json-valid
JS library)
Tricky, because I'd think in some cases you'd want it to fail, and in some (such as the winding issue), passing with a warning should suffice. But I don't know if there is that much granularity in the linter output?
I would think depending on geojsonlint
R package makes sense, so you've not duplicating functionality. In rmapshaper
I'm kind of toying with the idea of getting rid of linting altogether and letting the user worry about it... Maybe include geojsonhint
in Suggests
and show its use in some examples?
I'm just now learning about linting, so I'll leave this to the both of you to decide...
okay, thanks jeff
Going to push this off until the next milestone.
Sorta complex. If we import geojsonlint
, then that will require installing httr
, not a huge deal, but kinda silly given we don't need to make http requests otherwise.
I think i remember wanting to keep linting at some point because errors returned from turf weren't always useful, but then again, the user can always do that themselves.