raspiblitz icon indicating copy to clipboard operation
raspiblitz copied to clipboard

[WebUI/API] CLN seedwords dont get listed correctly with numbers

Open rootzoll opened this issue 1 year ago • 1 comments

When installing a fresh Core Lightning Wallet thru the redesigned Setup WebUI the seed words looks like this:

Bildschirmfoto 2024-08-15 um 14 28 46

Not sure if this is to fix thru WebUI @cstenglein or API @fusion44 or even the wallet creating shell script @openoms .. but the data structure should be similar to the LND so that it gets rendered correctly.

Its not critical but should get fixed for 1.11.3 release.

rootzoll avatar Aug 15 '24 12:08 rootzoll

The seedwords are expected in this format:

https://github.com/raspiblitz/raspiblitz-web/blob/master/backend-mock/setup.js#L125

They are split by ", " https://github.com/raspiblitz/raspiblitz-web/blob/master/src/pages/Setup/FinalDialog.tsx#L24

Most likely it is because they are separated by just an empty space, not a comma and an empty space.

cstenglein avatar Aug 15 '24 16:08 cstenglein

@rootzoll check script for same splitting char as LND

rootzoll avatar Sep 23 '24 19:09 rootzoll

If splitting is not done in the LND script, I'll handle the case in the webUI

cstenglein avatar Sep 26 '24 16:09 cstenglein

OK comitted to dev branch - cln script should now deliver thru API the comma separated list - like in this example:

seedwords='wall,input,chronic,gaze,tip,explain,fog,receive,kingdom,they,corn,universe,soup,roast,remind,country,make,harsh,dream,cross,all,magic,napkin,found'

rootzoll avatar Sep 26 '24 17:09 rootzoll

TODO-TEST: With v1.11.3rc1 test fresh setup of cln node and check seed word listing.

rootzoll avatar Sep 26 '24 17:09 rootzoll

OK comitted to dev branch - cln script should now deliver thru API the comma separated list - like in this example:

seedwords='wall,input,chronic,gaze,tip,explain,fog,receive,kingdom,they,corn,universe,soup,roast,remind,country,make,harsh,dream,cross,all,magic,napkin,found'

There is a " " missing after the comma :/

It should be seedwords='wall, input, chronic, gaze, tip, explain, fog, receive, kingdom, ...

cstenglein avatar Sep 26 '24 17:09 cstenglein

@cstenglein comma separated should now contain also the space

TODO-TEST: With v1.11.3rc1 test fresh setup of cln node and check seed word listing.

rootzoll avatar Sep 26 '24 17:09 rootzoll