raspiblitz icon indicating copy to clipboard operation
raspiblitz copied to clipboard
verified publisher icon rootzoll

[Scripts/API] Correctly use installed/configured

Open rootzoll opened this issue 1 year ago • 2 comments

See https://github.com/raspiblitz/raspiblitz/issues/4649#issuecomment-2241295258 .. with v1.12.0 we should correct all fatpack scripts to correctly show installed and configured status and the API then need to adapt to that change for the new version.

rootzoll avatar Jul 20 '24 21:07 rootzoll

Ok, as I see it right now:

  • configured determines whether the service is actually running (status on or off)
    • this is switched by clicking install on the UI
  • installed determines whether the binaries are installed on the system via some means
    • this is irrelevant for the webui

fusion44 avatar Jul 20 '24 22:07 fusion44

Okay sorry. Now that I understand the problem better it is an API problem. I always mistook installed as on. The distinction makes sense in a RaspiBlitz context.

I'll fix it properly. Longer term, maybe we can rename the installed var to something like binary_exists or binary_installed to make it more clear for other new contributors.

fusion44 avatar Jul 21 '24 04:07 fusion44

Recommend to move to v1.12.1 - there is already a lot of infrastructure changing with v1.12.0

geco91 avatar May 26 '25 11:05 geco91