rails_api_base icon indicating copy to clipboard operation
rails_api_base copied to clipboard

Published 20 hours ago • verified publisher icon rootstrap

Feature/improve ruby version to 3.1.2

Open claudiokerekes opened this issue 2 years ago • 4 comments

Board:

Description:

  • Update ruby version to 3.1.2

Notes:

  • include Pundit is deprecated
  • few gems had to be updated for proper operation. Check Gemfile

Tasks:

  • [ ] run rubocop and fix linter errors. Maybe in another PR?

Risk:

  • None at the moment

image

claudiokerekes avatar Oct 06 '22 16:10 claudiokerekes

I think linter errors should be updated in another issue @sebaherrera07 , @santib. wdyt?

claudiokerekes avatar Oct 07 '22 14:10 claudiokerekes

I think linter errors should be updated in another issue @sebaherrera07 , @santib. wdyt?

hmm I don't think so, I don't want to have a broken CI in the main branch. BTW the broken linters are caused by this PR, they are working fine in the main branch, so I think it's fair to fix them here

santib avatar Oct 07 '22 14:10 santib

I think linter errors should be updated in another issue @sebaherrera07 , @santib. wdyt?

If you want, yo can make a separate PR with this one as the base, and then we can review the linters changes separately. But we can't merge this PR with the linters broken! 😄

sebaherrera07 avatar Oct 07 '22 14:10 sebaherrera07

please check @rootstrap/open-source-ruby-maintainers please check

claudiokerekes avatar Oct 07 '22 17:10 claudiokerekes