bud icon indicating copy to clipboard operation
bud copied to clipboard

Bump schema version from 2 to 3

Open joshuafredrickson opened this issue 1 year ago • 2 comments

Version 3 is now supported in WordPress 6.6.

Reference: https://developer.wordpress.org/block-editor/reference-guides/theme-json-reference/theme-json-living/

Migrating from v2 to v3: https://developer.wordpress.org/block-editor/reference-guides/theme-json-reference/theme-json-migrations/#migrating-from-v2-to-v3

Type of change

PATCH: backwards compatible change

This doesn't appear to break anything. Although, there are migration steps in the link above that add two default values: settings.typography.defaultFontSizes and settings.spacing.defaultSpacingSizes.

joshuafredrickson avatar Sep 12 '24 21:09 joshuafredrickson

Sorry for the delay! This looks great & thank you for your work on it.

Looks like the tests are failing, which is good. Could you run the following two commands and commit the new snapshots?

yarn @bud test unit --update
yarn @bud test integration --update

kellymears avatar Oct 01 '24 05:10 kellymears

Sure thing! Ran them and committed, but bumped into an AWS access key error on tests/reproductions/issue-2574.test.ts.

joshuafredrickson avatar Oct 01 '24 23:10 joshuafredrickson

Any updates on whether this will be implemented soon? 6.7 will be released today and it's quite important to be using theme.json schema version 3 to have access to new properties

stevencamilleri-g2m avatar Nov 12 '24 11:11 stevencamilleri-g2m