Alexander Root

Results 63 comments of Alexander Root

Doesn't seem like it was, the commit before #6083 still doesn't have the bug

Harris on master still fails with OOB, so this is still an issue.

`bound_small_allocations()` is calling the new version(s) of `find_constant_bound(s)`, which means that there is likely an allocation expression that is tripping up the new method - if you could log which...

Is it possible to know if the scope has any values actually set? Sorry, I didn't realize that printing scope only prints the names, I need the corresponding intervals as...

Definitely seems like the issue here is `substitute_some_lets`. Not sure exactly what the count should be, but 100 is too high

@steven-johnson Do you think you could run Google testing again? I think my tests just never had such enormous expressions, the example you provided should end reasonably fast now.

@steven-johnson Thanks for the feedback, I added documentation explaining the chosen value.

Thanks @steven-johnson ! @abadams good to go?

No - I still need to address Andrew's point on using deep_equality, and still need feedback on the substiution. Sorry for dropping the ball on this, I was out for...

Thanks! I hope it was a fun vacation!