web icon indicating copy to clipboard operation
web copied to clipboard

Core dependencies not mentioned on dependencies page

Open eguiraud opened this issue 4 years ago • 7 comments

The problem: as a user I visited https://root.cern/install/dependencies, I have installed required as well as optional dependencies, and yet configuring a build with cmake -Dfail-on-missing=ON ../root_src does not work, because I'm missing dependencies (or I have to manually turn on their built-in versions.

The minimal working configuration I found was

cmake -Dbuiltin_zstd=ON -Dbuiltin_xxhash=ON -Dfail-on-missing=ON -Dbuiltin_lz4=ON -Dbuiltin_afterimage=ON -Dbuiltin_gl2ps=ON -Doracle=OFF -Dpythia6=OFF -Dpythia8=OFF -Dxrootd=OFF -Dgfal=OFF -Dbuiltin_tbb=ON -Dbuiltin_vdt=ON ../root_src

and note that if I set any of those builtins to OFF, configuration fails.

I think core dependencies that are required for ROOT to work, lest it cannot build, should be listed as dependencies in https://root.cern/install/dependencies.

From Oksana:

in theory there should be libz liblzma liblz4 (it get xxhash as a dependency) and libzstd

I don't know where gl2ps or vdt lie.

eguiraud avatar Aug 06 '20 14:08 eguiraud

But IIUC and IMO these builtins are optional dependencies, as ROOT can build without them being installed, by taking its own.

Axel-Naumann avatar Aug 06 '20 15:08 Axel-Naumann

@Axel-Naumann don't you agree that, after installing all dependencies listed at https://root.cern/install/dependencies, the following should work?

cmake -Dfail-on-missing=ON ../root_src

eguiraud avatar Aug 13 '20 09:08 eguiraud

@oshadura : I assigned it to you. Feel free to assign it to somebody else if you think that's not your domain.

couet avatar Mar 16 '21 08:03 couet

@eguiraud before I start to look at this, is it still relevant?

bellenot avatar Jul 15 '21 07:07 bellenot

Yes, the page does not list all required dependencies.

Axel-Naumann avatar Jul 15 '21 07:07 Axel-Naumann

@eguiraud

don't you agree that, after installing all dependencies listed at https://root.cern/install/dependencies, the following should work? cmake -Dfail-on-missing=ON ../root_src

Yes, after installing all required dependencies this command must work.

Axel-Naumann avatar Jul 15 '21 07:07 Axel-Naumann

OK, I'll check on all platforms

bellenot avatar Jul 15 '21 07:07 bellenot