rootbench icon indicating copy to clipboard operation
rootbench copied to clipboard

Make sure all integration benchmarks run with equal file cache conditions

Open eguiraud opened this issue 5 years ago • 1 comments

Currently we have a few integration benchmarks that only execute a single repetition, but some of these benchmarks share input files. As a consequence, the first of these benchmarks would run on a cold file cache and the others on a warm cache. We have to normalize this, e.g. by having each integration test run two iterations and discarding the runtime of the first.

eguiraud avatar Jul 16 '20 16:07 eguiraud

Isn't that a job of the benchmark itself rather than the infrastructure?

The benchmark author should ensure the run conditions in the benchmark initialization phase. Indeed if the intent is to benchmark on cold cache, then we have a little to do as previous benchmarks may have forced the kernel to load data files.

I would be in favor of that approach rather controlling this indirectly by infrastructure at the cost of making it complicated.

Do you see such effect somewhere at the moment?

vgvassilev avatar Aug 29 '20 14:08 vgvassilev