[Win] Warnings about missing PCMs

[hageboeck]

Cling warns about missing PCMs on windows.

1. Revert e3f2ed26b7903ff540a37e77f6c026b8502db747
2. Fix the warnings in the failing tests.

[dpiparo]

Is this still an issue?

[guitargeek]

Let's find it out! #15186.

[guitargeek]

It is still an issue on both Windows 64 bit and 32 bit as of April 2024.

Here is the relevant output:

2206/2226 Test #2197: gtestC--ROOT-CI-roottest-root-tree-readrules-gh-14462-gh14462regression ...........................***Failed    1.06 sec
  Running main() from C:\ROOT-CI\build\googletest-prefix\src\googletest\googletest\src\gtest_main.cc
  [==========] Running 1 test from 1 test suite.
  [----------] Global test environment set-up.
  [----------] 1 test from ReadRules
  [ RUN      ] ReadRules.CustomReadRuleWithSpace
  C:\ROOT-CI\src\core\testsupport\src\TestSupport.cxx(76): error: Failed
  Received unexpected diagnostic of severity 3000 at 'TCling::LoadPCM' reading 'ROOT PCM C:\ROOT-CI\build\roottest\root\tree\readrules\gh-14462\Release\gh14462regressionDict_rdict.pcm file does not exist'.
  Suppress those using ROOT/TestSupport.hxx
  [  FAILED  ] ReadRules.CustomReadRuleWithSpace (883 ms)
  [----------] 1 test from ReadRules (883 ms total)
  
  [----------] Global test environment tear-down
  [==========] 1 test from 1 test suite ran. (883 ms total)
  [  PASSED  ] 0 tests.
  [  FAILED  ] 1 test, listed below:
  [  FAILED  ] ReadRules.CustomReadRuleWithSpace
  
   1 FAILED TEST
  CMake Error at C:/ROOT-CI/build/RootTestDriver.cmake:232 (message):
    error code: 1

[bellenot]

Here is the current status:

C:\root-dev\build\x64\relwithdebinfo>ctest -VV -C RelWithDebInfo -R gh-14462-gh14462regression
UpdateCTestConfiguration  from :C:/root-dev/build/x64/relwithdebinfo/DartConfiguration.tcl
Parse Config file:C:/root-dev/build/x64/relwithdebinfo/DartConfiguration.tcl
 Add coverage exclude regular expressions.
UpdateCTestConfiguration  from :C:/root-dev/build/x64/relwithdebinfo/DartConfiguration.tcl
Parse Config file:C:/root-dev/build/x64/relwithdebinfo/DartConfiguration.tcl
Test project C:/root-dev/build/x64/relwithdebinfo
Constructing a list of tests
Ignore test: test-tcollex
Ignore test: roottest-cling-parsing-semicolon
Ignore test: roottest-root-rint-TabCom
Ignore test: roottest-root-rint-BackslashNewline
Done constructing a list of tests
Updating test list for fixtures
Added 0 tests to meet fixture requirements
Checking test dependency graph...
Checking test dependency graph end
test 2338
    Start 2338: gtestC--root-dev-git-roottest-root-tree-readrules-gh-14462-gh14462regression

2338: Test command: "C:\Program Files\CMake\bin\cmake.exe" "-DCMD=C:/root-dev/build/x64/relwithdebinfo/roottest/root/tree/readrules/gh-14462/RelWithDebInfo/gh14462regression.exe" "-DCWD=C:/root-dev/build/x64/relwithdebinfo/roottest/root/tree/readrules/gh-14462" "-DSYS=C:/root-dev/build/x64/relwithdebinfo" "-P" "C:/root-dev/build/x64/relwithdebinfo/RootTestDriver.cmake"
2338: Working Directory: C:/root-dev/build/x64/relwithdebinfo/roottest/root/tree/readrules/gh-14462
2338: Environment variables:
2338:  ROOT_HIST=0
2338: Test timeout computed to be: 1500
2338: Running main() from C:\root-dev\build\x64\relwithdebinfo\googletest-prefix\src\googletest\googletest\src\gtest_main.cc
2338: [==========] Running 1 test from 1 test suite.
2338: [----------] Global test environment set-up.
2338: [----------] 1 test from ReadRules
2338: [ RUN      ] ReadRules.CustomReadRuleWithSpace
2338: Error in TCling::LoadPCM ROOT PCM C:\root-dev\build\x64\relwithdebinfo\roottest\root\tree\readrules\gh-14462\RelWithDebInfo\gh14462regressionDict_rdict.pcm file does not exist
2338: [       OK ] ReadRules.CustomReadRuleWithSpace (317 ms)
2338: [----------] 1 test from ReadRules (317 ms total)
2338:
2338: [----------] Global test environment tear-down
2338: [==========] 1 test from 1 test suite ran. (317 ms total)
2338: [  PASSED  ] 1 test.
1/1 Test #2338: gtestC--root-dev-git-roottest-root-tree-readrules-gh-14462-gh14462regression ...   Passed    0.41 sec

The following tests passed:
        gtestC--root-dev-git-roottest-root-tree-readrules-gh-14462-gh14462regression

100% tests passed, 0 tests failed out of 1

Total Test time (real) =   0.92 sec

But it's correct. When moving the PCM at the right place, it stops complaining (i.e. the PCM should be copied/moved to the test binary output directory. Or did I miss something?

[bellenot]

FYI I have a solution for gh14462regression, but I'm looking for a global solution...