root icon indicating copy to clipboard operation
root copied to clipboard

[core] ACLiC: speed up building / loading:

Open Axel-Naumann opened this issue 4 years ago • 59 comments

Instead of looking for libraries resolving each unresolved symbol, just load each lib resolving symbols: this will allow subsequent missing symbols to be resolved from the loaded library quickly, without touching disk.

When loading an existing ACLiC library, and if we expect it to contain the dependencies (explicit linking), just load itt, instead of trying to (re-)determine its dependencies from its undefined symbols: the outcome should be just the library dependencies we expect the library to know already.

Axel-Naumann avatar Apr 27 '21 16:04 Axel-Naumann

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14 How to customize builds

phsft-bot avatar Apr 27 '21 16:04 phsft-bot

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14 How to customize builds

phsft-bot avatar Apr 27 '21 16:04 phsft-bot

Build failed on ROOT-fedora30/cxx14. Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2021-04-27T16:50:46.080Z] FAILED: core/metacling/src/CMakeFiles/MetaCling.dir/TCling.cxx.o
  • [2021-04-27T16:50:46.338Z] /home/sftnight/build/workspace/root-pullrequests-build/root/core/metacling/src/TCling.cxx:7209:27: error: cannot convert ‘std::string’ {aka ‘std::__cxx11::basic_string<char>’} to ‘const char*’

phsft-bot avatar Apr 27 '21 16:04 phsft-bot

Build failed on ROOT-fedora31/noimt. Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2021-04-27T16:51:21.339Z] /home/sftnight/build/workspace/root-pullrequests-build/root/core/metacling/src/TCling.cxx:7209:27: error: cannot convert ‘std::string’ {aka ‘std::__cxx11::basic_string<char>’} to ‘const char*’

phsft-bot avatar Apr 27 '21 16:04 phsft-bot

Build failed on ROOT-ubuntu16/nortcxxmod. Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2021-04-27T16:51:56.108Z] FAILED: /usr/bin/ccache /usr/bin/c++ -I/mnt/build/workspace/root-pullrequests-build/root/interpreter/cling/include -I/mnt/build/workspace/root-pullrequests-build/root/core/metacling/res -I/mnt/build/workspace/root-pullrequests-build/root/core/clingutils/res -I/mnt/build/workspace/root-pullrequests-build/root/core/foundation/res -I/mnt/build/workspace/root-pullrequests-build/root/core/zip/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/clib/res -I/mnt/build/workspace/root-pullrequests-build/root/core/base/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/meta/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/clib/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/foundation/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/thread/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/cont/inc -I/mnt/build/workspace/root-pullrequests-build/root/core/gui/inc -I/mnt/build/workspace/root-pullrequests-build/root/io/io/inc -Iginclude -isystem /mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/tools/clang/include -isystem interpreter/llvm/src/tools/clang/include -isystem /mnt/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/include -isystem interpreter/llvm/src/include -fdiagnostics-color=always -std=c++11 -pipe -Wshadow -Wall -W -Woverloaded-virtual -fsigned-char -pthread -D_GNU_SOURCE -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -fvisibility=hidden -fno-strict-aliasing -Wwrite-strings -Wno-shadow -Wno-unused-parameter -Wno-deprecated-declarations -O3 -fPIC -std=c++11 -MD -MT core/metacling/src/CMakeFiles/MetaCling.dir/TCling.cxx.o -MF core/metacling/src/CMakeFiles/MetaCling.dir/TCling.cxx.o.d -o core/metacling/src/CMakeFiles/MetaCling.dir/TCling.cxx.o -c /mnt/build/workspace/root-pullrequests-build/root/core/metacling/src/TCling.cxx
  • [2021-04-27T16:51:56.108Z] /mnt/build/workspace/root-pullrequests-build/root/core/metacling/src/TCling.cxx:7209:31: error: no matching function for call to ‘TSystem::Load(std::__cxx11::string&)’

phsft-bot avatar Apr 27 '21 16:04 phsft-bot

Build failed on ROOT-performance-centos8-multicore/default. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Errors:

  • [2021-04-27T16:54:20.077Z] /data/sftnight/workspace/root-pullrequests-build/root/core/metacling/src/TCling.cxx:7209:31: error: no matching function for call to ‘TSystem::Load(std::__cxx11::string&)’

phsft-bot avatar Apr 27 '21 16:04 phsft-bot

Build failed on mac11.0/cxx17. Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2021-04-27T17:04:21.074Z] FAILED: core/metacling/src/CMakeFiles/MetaCling.dir/TCling.cxx.o
  • [2021-04-27T17:04:21.341Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/core/metacling/src/TCling.cxx:7209:27: error: no viable conversion from 'std::string' (aka 'basic_string<char, char_traits<char>, allocator<char> >') to 'const char *'

phsft-bot avatar Apr 27 '21 17:04 phsft-bot

Build failed on ROOT-debian10-i386/cxx14. Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2021-04-27T17:03:41.617Z] /home/sftnight/build/workspace/root-pullrequests-build/root/core/metacling/src/TCling.cxx:7209:31: error: no matching function for call to ‘TSystem::Load(std::__cxx11::string&)’

phsft-bot avatar Apr 27 '21 17:04 phsft-bot

Build failed on mac1014/python3. Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2021-04-27T17:22:21.283Z] FAILED: core/metacling/src/CMakeFiles/MetaCling.dir/TCling.cxx.o
  • [2021-04-27T17:22:21.853Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/core/metacling/src/TCling.cxx:7209:27: error: no viable conversion from 'std::string' (aka 'basic_string<char, char_traits<char>, allocator<char> >') to 'const char *'

phsft-bot avatar Apr 27 '21 17:04 phsft-bot

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14 How to customize builds

phsft-bot avatar Apr 27 '21 17:04 phsft-bot

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14 How to customize builds

phsft-bot avatar Apr 27 '21 18:04 phsft-bot

Build failed on ROOT-fedora31/noimt. Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Warnings:

  • [2021-04-27T18:55:01.262Z] /home/sftnight/build/workspace/root-pullrequests-build/root/core/base/src/TSystem.cxx:3326:21: warning: unused variable ‘onetime’ [-Wunused-variable]

Failing tests:

phsft-bot avatar Apr 27 '21 19:04 phsft-bot

Build failed on ROOT-fedora30/cxx14. Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Warnings:

  • [2021-04-27T18:55:03.305Z] /home/sftnight/build/workspace/root-pullrequests-build/root/core/base/src/TSystem.cxx:3326:21: warning: unused variable ‘onetime’ [-Wunused-variable]

Failing tests:

phsft-bot avatar Apr 27 '21 19:04 phsft-bot

Build failed on ROOT-performance-centos8-multicore/default. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Warnings:

  • [2021-04-27T18:53:05.118Z] /data/sftnight/workspace/root-pullrequests-build/root/core/base/src/TSystem.cxx:3326:21: warning: unused variable ‘onetime’ [-Wunused-variable]

Failing tests:

phsft-bot avatar Apr 27 '21 19:04 phsft-bot

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14 How to customize builds

phsft-bot avatar Apr 27 '21 19:04 phsft-bot

I'll clean up git history once the tests pass - there's https://github.com/root-project/roottest/pull/699 and the very different projectroot.core.metacling.test.gtest_core_metacling_test_TClingTest

Axel-Naumann avatar Apr 27 '21 19:04 Axel-Naumann

@phsft-bot build

Axel-Naumann avatar Apr 28 '21 04:04 Axel-Naumann

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14 How to customize builds

phsft-bot avatar Apr 28 '21 04:04 phsft-bot