root icon indicating copy to clipboard operation
root copied to clipboard

Enable `cling-test` for nightly, PR builds

Open SimeonEhrig opened this issue 5 years ago • 7 comments

I have question. Does roottest runs cmake --build . --target cling-test when the cling interpreter code is changed? From time to time I see, that commits are merged regardless of whether the CI fails. If I understand Cling's workflow correctly, changes are integrated and tested in ROOT and automatically streamed down to Cling after the merge in ROOT. So, if roottest does not run the integrated tests in cling, it is possible that the Cling CI is bypassed, or I'm wrong?

SimeonEhrig avatar Dec 16 '20 08:12 SimeonEhrig

cling-test is part of the test suite run with ctest if ROOT is configured with -Dclingtest=On. You can trigger Jenkins to do that by saying @phsft-bot build with flags -Dclingtest=On. But I agree it would make sense to turn it on by default for PR and nightly builds.

Axel-Naumann avatar Dec 18 '20 11:12 Axel-Naumann

@Axel-Naumann That sounds like a great idea.

SimeonEhrig avatar Dec 21 '20 08:12 SimeonEhrig

@hahnjo @devajithvs @vgvassilev I can enable these tests for 2-3 platforms in master: what do you think?

dpiparo avatar Apr 25 '24 07:04 dpiparo

Sounds good to me.

vgvassilev avatar Apr 25 '24 07:04 vgvassilev

clingtest exports many more symbols from libCling, for testing purposes (see the code in interpreter/CMakeLists.txt). This means our (patched) LLVM and Clang will interfere with other LLVM installations used by dependent libraries. IIRC this can make tests fail!

hahnjo avatar Apr 25 '24 07:04 hahnjo

What then could be a good way to make progress about this issue?

dpiparo avatar May 17 '24 07:05 dpiparo

clingtest exports many more symbols from libCling, for testing purposes (see the code in interpreter/CMakeLists.txt). This means our (patched) LLVM and Clang will interfere with other LLVM installations used by dependent libraries. IIRC this can make tests fail!

We will build that version of ROOT only to run clingtest, right? We still will test ROOT the regular way.

vgvassilev avatar May 17 '24 07:05 vgvassilev