root icon indicating copy to clipboard operation
root copied to clipboard

Published 20 hours ago • verified publisher icon root-project

[histv7] WIP: Fitting for RHist

Open claireguyot opened this issue 4 years ago • 6 comments

Changes are not yet functional. I did my best at finishing all I could, but there are still some errors I couldn't correct in time. Because of these errors, I also wasn't able to test the changes with the fit.cxx file.

claireguyot avatar Jul 30 '20 13:07 claireguyot

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14 How to customize builds

phsft-bot avatar Jul 30 '20 13:07 phsft-bot

Build failed on ROOT-fedora30/cxx14. Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See cdash. See console output.

Errors:

  • [2020-07-30T13:19:46.649Z] FAILED: hist/histv7/test/CMakeFiles/histhistv7testUnit.dir/fit.cxx.o
  • [2020-07-30T13:19:46.915Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:106:18: error: no match for call to ‘(TF1) (ROOT::Experimental::Detail::RHistBinRef<ROOT::Experimental::Detail::RHistImplBase<ROOT::Experimental::Detail::RHistData<1, double, std::vector<double>, ROOT::Experimental::RHistStatContent, ROOT::Experimental::RHistStatUncertainty> > >&)’
  • [2020-07-30T13:19:46.916Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:113:13: error: no matching function for call to ‘ROOT::Fit::BinData::Add(ROOT::Experimental::Detail::RHistBinRef<ROOT::Experimental::Detail::RHistImplBase<ROOT::Experimental::Detail::RHistData<1, double, std::vector<double>, ROOT::Experimental::RHistStatContent, ROOT::Experimental::RHistStatUncertainty> > >::CoordArray_t, double)’
  • [2020-07-30T13:19:46.916Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:116:35: error: cannot bind non-const lvalue reference of type ‘double&’ to an rvalue of type ‘double’
  • [2020-07-30T13:19:46.916Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:118:13: error: no matching function for call to ‘ROOT::Fit::BinData::Add(ROOT::Experimental::Detail::RHistBinRef<ROOT::Experimental::Detail::RHistImplBase<ROOT::Experimental::Detail::RHistData<1, double, std::vector<double>, ROOT::Experimental::RHistStatContent, ROOT::Experimental::RHistStatUncertainty> > >::CoordArray_t, double, double)’
  • [2020-07-30T13:19:46.916Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:173:26: error: no matching function for call to ‘BinContentToBinData(ROOT::Experimental::RHist<1, double, ROOT::Experimental::RHistStatContent, ROOT::Experimental::RHistStatUncertainty>&, std::shared_ptr<ROOT::Fit::BinData>&, TF1*&, ROOT::Fit::DataOptions&, ROOT::Fit::DataRange&)’

Warnings:

  • [2020-07-30T13:19:46.915Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/test/fit.cxx:25:14: warning: variable ‘chi2ref’ set but not used [-Wunused-but-set-variable]
  • [2020-07-30T13:19:46.917Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/test/fit.cxx:78:4: warning: control reaches end of non-void function [-Wreturn-type]

phsft-bot avatar Jul 30 '20 13:07 phsft-bot

Build failed on mac1015/cxx17. Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build See cdash. See console output.

Errors:

  • [2020-07-30T13:36:07.542Z] FAILED: hist/histv7/test/CMakeFiles/histhistv7testUnit.dir/fit.cxx.o
  • [2020-07-30T13:36:08.133Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:106:13: error: no matching function for call to object of type 'TF1'
  • [2020-07-30T13:36:08.428Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:113:21: error: no matching member function for call to 'Add'
  • [2020-07-30T13:36:08.428Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:173:7: error: no matching function for call to 'BinContentToBinData'

Warnings:

  • [2020-07-30T13:36:08.133Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/hist/histv7/test/fit.cxx:78:4: warning: control may reach end of non-void lambda [-Wreturn-type]

phsft-bot avatar Jul 30 '20 13:07 phsft-bot

Build failed on windows10/cxx14. Running on null:C:\build\workspace\root-pullrequests-build See cdash. See console output.

Errors:

  • [2020-07-30T14:02:44.253Z] C:\build\workspace\root-pullrequests-build\root\hist\histv7\inc\ROOT/RFitImpl.hxx(106,1): error C2664: 'Double_t TF1::operator ()(Double_t,Double_t,Double_t,Double_t) const': cannot convert argument 1 from 'ROOT::Experimental::Detail::RHistBinRef<HISTIMPL>' to 'Double_t' [C:\build\workspace\root-pullrequests-build\build\hist\histv7\test\histhistv7testUnit.vcxproj]
  • [2020-07-30T14:02:44.253Z] C:\build\workspace\root-pullrequests-build\root\hist\histv7\inc\ROOT/RFitImpl.hxx(106,1): error C2664: with [C:\build\workspace\root-pullrequests-build\build\hist\histv7\test\histhistv7testUnit.vcxproj]
  • [2020-07-30T14:02:44.253Z] C:\build\workspace\root-pullrequests-build\root\hist\histv7\inc\ROOT/RFitImpl.hxx(106,1): error C2664: [ [C:\build\workspace\root-pullrequests-build\build\hist\histv7\test\histhistv7testUnit.vcxproj]
  • [2020-07-30T14:02:44.253Z] C:\build\workspace\root-pullrequests-build\root\hist\histv7\inc\ROOT/RFitImpl.hxx(106,1): error C2664: HISTIMPL=ROOT::Experimental::Detail::RHistImplBase<ROOT::Experimental::Detail::RHistData<1,double,std::vector<double,std::allocator<double>>,ROOT::Experimental::RHistStatContent,ROOT::Experimental::RHistStatUncertainty>> [C:\build\workspace\root-pullrequests-build\build\hist\histv7\test\histhistv7testUnit.vcxproj]
  • [2020-07-30T14:02:44.253Z] C:\build\workspace\root-pullrequests-build\root\hist\histv7\inc\ROOT/RFitImpl.hxx(106,1): error C2664: ] [C:\build\workspace\root-pullrequests-build\build\hist\histv7\test\histhistv7testUnit.vcxproj]
  • [2020-07-30T14:02:44.254Z] C:\build\workspace\root-pullrequests-build\root\hist\histv7\inc\ROOT/RFitImpl.hxx(113,1): error C2664: 'void ROOT::Fit::BinData::Add(const double *,double,const double *,double,double)': cannot convert argument 1 from 'ROOT::Experimental::Hist::RCoordArray<1>' to 'double' [C:\build\workspace\root-pullrequests-build\build\hist\histv7\test\histhistv7testUnit.vcxproj]
  • [2020-07-30T14:02:44.254Z] C:\build\workspace\root-pullrequests-build\root\hist\histv7\inc\ROOT/RFitImpl.hxx(116,1): error C2664: 'bool ROOT::Experimental::RFit::AdjustError(const ROOT::Fit::DataOptions &,double &,double)': cannot convert argument 2 from 'double' to 'double &' [C:\build\workspace\root-pullrequests-build\build\hist\histv7\test\histhistv7testUnit.vcxproj]
  • [2020-07-30T14:02:44.254Z] C:\build\workspace\root-pullrequests-build\root\hist\histv7\inc\ROOT/RFitImpl.hxx(118,1): error C2664: 'void ROOT::Fit::BinData::Add(const double *,double,const double *,double,double)': cannot convert argument 1 from 'ROOT::Experimental::Hist::RCoordArray<1>' to 'double' [C:\build\workspace\root-pullrequests-build\build\hist\histv7\test\histhistv7testUnit.vcxproj]

phsft-bot avatar Jul 30 '20 14:07 phsft-bot

Build failed on ROOT-ubuntu16/nortcxxmod. Running on sft-ubuntu-1604-4.cern.ch:/build/workspace/root-pullrequests-build See cdash. See console output.

Failing tests:

phsft-bot avatar Jul 30 '20 14:07 phsft-bot

Build failed on ROOT-debian10-i386/cxx14. Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build See cdash. See console output.

Errors:

  • [2020-07-31T11:52:13.880Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:106:18: error: no match for call to ‘(TF1) (ROOT::Experimental::Detail::RHistBinRef<ROOT::Experimental::Detail::RHistImplBase<ROOT::Experimental::Detail::RHistData<1, double, std::vector<double>, ROOT::Experimental::RHistStatContent, ROOT::Experimental::RHistStatUncertainty> > >&)’
  • [2020-07-31T11:52:13.880Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:113:13: error: no matching function for call to ‘ROOT::Fit::BinData::Add(ROOT::Experimental::Detail::RHistBinRef<ROOT::Experimental::Detail::RHistImplBase<ROOT::Experimental::Detail::RHistData<1, double, std::vector<double>, ROOT::Experimental::RHistStatContent, ROOT::Experimental::RHistStatUncertainty> > >::CoordArray_t, double)’
  • [2020-07-31T11:52:13.880Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:116:35: error: cannot bind non-const lvalue reference of type ‘double&’ to an rvalue of type ‘double’
  • [2020-07-31T11:52:13.880Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:118:13: error: no matching function for call to ‘ROOT::Fit::BinData::Add(ROOT::Experimental::Detail::RHistBinRef<ROOT::Experimental::Detail::RHistImplBase<ROOT::Experimental::Detail::RHistData<1, double, std::vector<double>, ROOT::Experimental::RHistStatContent, ROOT::Experimental::RHistStatUncertainty> > >::CoordArray_t, double, double)’
  • [2020-07-31T11:52:13.881Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/inc/ROOT/RFitImpl.hxx:173:26: error: no matching function for call to ‘BinContentToBinData(ROOT::Experimental::RHist<1, double, ROOT::Experimental::RHistStatContent, ROOT::Experimental::RHistStatUncertainty>&, std::shared_ptr<ROOT::Fit::BinData>&, TF1*&, ROOT::Fit::DataOptions&, ROOT::Fit::DataRange&)’

Warnings:

  • [2020-07-31T11:52:13.880Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/test/fit.cxx:25:14: warning: variable ‘chi2ref’ set but not used [-Wunused-but-set-variable]
  • [2020-07-31T11:52:13.881Z] /home/sftnight/build/workspace/root-pullrequests-build/root/hist/histv7/test/fit.cxx:78:4: warning: control reaches end of non-void function [-Wreturn-type]

phsft-bot avatar Jul 31 '20 11:07 phsft-bot