root icon indicating copy to clipboard operation
root copied to clipboard

minicern fixes

Open couet opened this issue 1 month ago • 4 comments

  • Put PAWC and QUEST common blocks to have a unique centralised definition
  • In kernlib.f: enlarge the size of the input string MT to be compatible with some calls.
  • In zebra.f: use pawc.inc and quest.inc
  • In hbook.f: use pawc.inc and quest.inc, fixes the output character strings called from C++

couet avatar Nov 27 '25 18:11 couet

Test Results

    21 files      21 suites   3d 17h 50m 54s ⏱️  3 777 tests  3 777 ✅ 0 💤 0 ❌ 77 471 runs  77 471 ✅ 0 💤 0 ❌

Results for commit ea2885c0.

github-actions[bot] avatar Nov 28 '25 01:11 github-actions[bot]

I can reproduce the crash on macphsft19.

couet avatar Nov 28 '25 14:11 couet

Maybe using https://cmake.org/cmake/help/latest/module/FortranCInterface.html, https://fortran-lang.discourse.group/t/cmake-fortrancinterface/7573 could help in simplifying the connection C - Fortran

ferdymercury avatar Dec 08 '25 09:12 ferdymercury

If I turn on Wall Wextra warnings via set_target_properties(minicern PROPERTIES COMPILE_FLAGS "-Wall -Wextra"), I see (https://github.com/root-project/root/actions/runs/20062341758/job/57542127199?pr=20538)

several warnings of the type:

 Warning: Array reference at (1) out of bounds (8729 > 8704) in loop beginning at (2) [-Wdo-subscript]
  /github/home/ROOT-CI/src/misc/minicern/src/zebra.f:574:45:

   /github/home/ROOT-CI/src/misc/minicern/src/hbook.f:2514:72:
  
   2514 |       BSLASH='\\'
        |                                                                        1
  Warning: CHARACTER expression will be truncated in assignment (1/2) at (1) [-Wcharacter-truncation]

ferdymercury avatar Dec 09 '25 15:12 ferdymercury