root icon indicating copy to clipboard operation
root copied to clipboard

Fix/tcolor preserve metadata

Open aviralgarg05 opened this issue 2 months ago • 3 comments

This Pull request:

Changes or fixes:

  • Add import functools to enable metadata preservation
  • Decorate wrapper function with @functools.wraps(original_init) to maintain name, doc, and wrapped attributes
  • Fixes TColor.DefinedColors(1) failure in Jupyter notebooks
  • Ensures proper method resolution in introspection-heavy environments

Checklist:

  • [x] tested changes locally
  • [x] updated the docs (if necessary)

This PR fixes #20018

aviralgarg05 avatar Oct 06 '25 21:10 aviralgarg05

Test Results

    22 files      22 suites   3d 22h 39m 47s ⏱️  3 781 tests  3 776 ✅ 0 💤  5 ❌ 81 252 runs  81 227 ✅ 0 💤 25 ❌

For more details on these failures, see this check.

Results for commit 104c3c96.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Oct 07 '25 01:10 github-actions[bot]

Thanks for this code. In order to start the review we would need to also have a test that reproduces the problem. Notebook tests are in this directory https://github.com/root-project/root/tree/master/roottest/python/JupyROOT

dpiparo avatar Oct 08 '25 05:10 dpiparo

I'll go through them and solve

aviralgarg05 avatar Nov 06 '25 08:11 aviralgarg05