root icon indicating copy to clipboard operation
root copied to clipboard

[TEST PR] CallFunc -> JitCall migration

Open aaronj0 opened this issue 8 months ago • 1 comments

Moving the default constructor execution (TClingCallFunc::ExecDefaultConstructor) to JitCall seems relatively stable on my system (down to 2 failing tests). This PR is not intended to be merged, but to evaluate the test results on all platforms and will be closed

aaronj0 avatar Apr 29 '25 13:04 aaronj0

Test Results

    20 files      20 suites   3d 5h 10m 27s ⏱️  3 066 tests  3 066 ✅ 0 💤 0 ❌ 59 724 runs  59 724 ✅ 0 💤 0 ❌

Results for commit 195a654b.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 29 '25 16:04 github-actions[bot]

@smuzaffar we believe these changes would benefit from a CMSSW CI run, could you help us with that?

vepadulano avatar Jun 24 '25 07:06 vepadulano

@vepadulano , cmssw ci tests are running via https://github.com/cms-sw/root/pull/225

smuzaffar avatar Jun 24 '25 16:06 smuzaffar

Hi @smuzaffar @vepadulano, Aaron and me can't see the build logs behind the CMS login. Can one of you CMS guys please check the logs and see if the failures are related, copy-pasting relevant error messages if there are any? Thanks!

guitargeek avatar Jun 25 '25 09:06 guitargeek

cmssw CI tests look good. The unit tests failure are not due to this change. https://github.com/cms-sw/cmssw/pull/48393 should fix those tests (#19096 : Root's removal of deprecated _TDirectory_getattr pythonization)

smuzaffar avatar Jun 25 '25 09:06 smuzaffar

@smuzaffar can we give another try of this pr in cmssw?

vgvassilev avatar Jun 27 '25 04:06 vgvassilev

@smuzaffar can we give another try of this pr in cmssw?

restarted cmssw ci tests

smuzaffar avatar Jun 27 '25 09:06 smuzaffar