[ntuple] Reader: add option to enable metrics on construction
This Pull request:
adds the possibility of requesting metrics in RNTupleReadOptions.
Since one normally has to call EnableMetrics() on the RNTupleReader to start collecting metrics, it is currently not possible to query the metrics gathered during construction of the reader itself. With this new option you can request metrics to be enabled at construction time.
As a somewhat arbitrary choice, an RNTupleReader created via Clone() will inherit this option from the one it is cloned from.
Checklist:
- [x] tested changes locally
- [ ] updated the docs (if necessary)
This PR fixes #
Thanks, this is useful! In a similar vein, perhaps it would also be nice to have a
HasMetricsEnabledmethod for the reader itself, especially if this option is inherited when cloning.
@enirolf I'm not sure that's necessary because one can already get that information with reader->GetMetrics().IsEnabled()
Test Results
13 files 13 suites 2d 22h 1m 45s :stopwatch: 2 651 tests 2 651 :white_check_mark: 0 :zzz: 0 :x: 32 645 runs 32 645 :white_check_mark: 0 :zzz: 0 :x:
Results for commit 12da709b.
Thanks, this is useful! In a similar vein, perhaps it would also be nice to have a
HasMetricsEnabledmethod for the reader itself, especially if this option is inherited when cloning.@enirolf I'm not sure that's necessary because one can already get that information with
reader->GetMetrics().IsEnabled()
Ah yes, you're right! I missed that method in the docs.