changed-in-PR filter of "clang-tools code analysis" workflow is leaky

[egpbos]

Explain what you would like to see improved and how.

The filter seems to include files that were changed since the last branch off of master. Take for instance https://github.com/root-project/root/actions/runs/9682129594/job/26714405775. The COMMIT_FILES variable contains many files not touched in this PR. This makes the output quite tedious to parse and the PR hard to improve.

ROOT version

Irrelevant, it is a CI issue.

Installation method

CI

Operating system

CI

Additional context

No response

[egpbos]

Possibly related: https://github.com/orgs/community/discussions/59677

[egpbos]

This could be a way to side-step the GitHub variable issue: https://stackoverflow.com/a/74268200

[hahnjo]

A possible workaround is to rebase, then you should only get exactly the files changed by the PR.

Let me also add @jblomer who last fixed the list of files the analysis workflow. Maybe there's an easy way we can only get the files changed by the PR no matter the state of master...

[egpbos]

A possible workaround is to rebase, then you should only get exactly the files changed by the PR.

Indeed, that works. The SO answer I linked to above provides a possible solution, but I haven't checked whether it completely matches the ROOT situation.

[github-actions[bot]]

Hi @dpiparo,

It appears this issue is closed, but wasn't yet added to a project. Please add upcoming versions that will include the fix, or 'not applicable' otherwise.

Sincerely, :robot: