root icon indicating copy to clipboard operation
root copied to clipboard

[DF] Make vector to RVec conversion optional in Snapshot() of RDF

Open TomasDado opened this issue 1 year ago • 3 comments

This Pull request makes the conversion of stl vectors to RVec optional when using Snapshot()

Changes or fixes:

Propagating the relevant flag to the Snapshot() call

Checklist:

  • [x] tested changes locally
  • [ ] updated the docs (if necessary)

This PR fixes #15503

TomasDado avatar Jun 20 '24 13:06 TomasDado

Thanks a lot for these changes. Let's see it working, then we can perhaps discuss whether this is an option to add to the Snapshot options, rather than extending the signature of Snapshot.

dpiparo avatar Jun 20 '24 13:06 dpiparo

Thanks for the comment, I updated the code to use the Snapshot options, the issue I saw was related to Define() and not Snapshot()

TomasDado avatar Jun 20 '24 14:06 TomasDado

Test Results

    17 files      17 suites   4d 2h 14m 49s :stopwatch:  2 713 tests  2 709 :white_check_mark: 0 :zzz: 4 :x: 43 513 runs  43 509 :white_check_mark: 0 :zzz: 4 :x:

For more details on these failures, see this check.

Results for commit b46e85f0.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jun 20 '24 16:06 github-actions[bot]