root icon indicating copy to clipboard operation
root copied to clipboard

[ntuple] write streamer info of used types to ROOT file

Open jblomer opened this issue 1 year ago • 1 comments

The file page sink, on commit, collects the streamer info records of custom classes. These records are passed together with the records from unsplit fields to the file writer, which will write them in the ROOT file streamer info record.

In the wake of this change, the minifile has been modified to let the ROOT streamers create the list of streamer info records. The hand-coded record for the RNTuple class was thus removed.

The change triggers / works around bug #15877

Fixes #14871

A separate PR to roottest should check the TFile::MakeProject() works as expected with RNTuple.

jblomer avatar Jun 18 '24 10:06 jblomer

Test Results

    13 files      13 suites   2d 11h 11m 59s :stopwatch:  3 027 tests  3 027 :white_check_mark: 0 :zzz: 0 :x: 33 832 runs  33 832 :white_check_mark: 0 :zzz: 0 :x:

Results for commit ff1aa41c.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jun 18 '24 13:06 github-actions[bot]

@pcanal: We start to need to rebase this. Also, it would be useful to have it merged to see the true file size in TTree/RNTuple comparisons, e.g. for CHEP, since this will make files with RNTuple data slightly larger. I'm going to merge now but of course I'll still incorporate comments from you.

jblomer avatar Sep 04 '24 07:09 jblomer