root icon indicating copy to clipboard operation
root copied to clipboard

[ntuple] Add support for `(unsigned) long long` fields

Open enirolf opened this issue 1 year ago • 4 comments

This PR adds support for (unsigned) long long fields, and in addition points (U)Long64_t-type fields here, instead of to std::(u)int64_t.

Still left TODO is properly check the width of this type, as well as long across different platforms

enirolf avatar Jun 13 '24 09:06 enirolf

FYI, on Windows, long is 32 bit on both x86 AND x64

bellenot avatar Jun 13 '24 11:06 bellenot

Test Results

     8 files       8 suites   2d 4h 18m 57s :stopwatch:  2 577 tests  2 577 :white_check_mark: 0 :zzz: 0 :x: 20 403 runs  20 403 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 940781c6.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jun 13 '24 11:06 github-actions[bot]

We may not need the template specialization in RColumnElement and RFieldVisitor. I think it should be enough to make the special treatment in RField. Let's discuss tomorrow.

jblomer avatar Jun 13 '24 13:06 jblomer

FYI, on Windows, long is 32 bit on both x86 AND x64

Yes; this PR is about long long which is guaranteed to be at least 64 bits by C++11.

hahnjo avatar Jun 13 '24 13:06 hahnjo

It's unclear to me why clang-format fails here. The supposed style violations seem to be in accordance to our .clang-format file and running clang-format locally no violations are reported..

enirolf avatar Jul 02 '24 06:07 enirolf

I guess this has been replaced by #16039

jblomer avatar Jul 25 '24 12:07 jblomer