root icon indicating copy to clipboard operation
root copied to clipboard
verified publisher icon root-project

[RF] Continue RooFit AD development

Open guitargeek opened this issue 1 year ago • 1 comments

Work in progress, to see if it works on all platforms.

guitargeek avatar May 23 '24 11:05 guitargeek

Test Results

    13 files      13 suites   3d 0h 16m 15s :stopwatch:  2 652 tests  2 652 :white_check_mark: 0 :zzz: 0 :x: 32 658 runs  32 658 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 15c3dd33.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 23 '24 16:05 github-actions[bot]

There seems to be a mac specific problem:

2024-06-27T16:52:12.5381030Z [/Users/sftnight/ROOT-CI/build/lib/libRooFitCore.so] RooMinimizerFcn::evaluateGradient(double const*, double*) const /Users/sftnight/ROOT-CI/src/roofit/roofitcore/src/RooMinimizerFcn.cxx:131
2024-06-27T16:52:12.5382300Z [/Users/sftnight/ROOT-CI/build/lib/libRooFitCore.so] ROOT::Math::GradFunctor::Gradient(double const*, double*) const /Users/sftnight/ROOT-CI/build/include/Math/Functor.h:222
2024-06-27T16:52:12.5383890Z [/Users/sftnight/ROOT-CI/build/lib/libMinuit2.so] ROOT::Minuit2::FCNGradAdapter<ROOT::Math::IGradientFunctionMultiDimTempl<double>>::Gradient(std::__1::vector<double, std::__1::allocator<double>> const&) const /Users/sftnight/ROOT-CI/src/math/minuit2/inc/Minuit2/FCNGradAdapter.h:50
2024-06-27T16:52:12.5385690Z [/Users/sftnight/ROOT-CI/build/lib/libMinuit2.so] ROOT::Minuit2::AnalyticalGradientCalculator::operator()(ROOT::Minuit2::MinimumParameters const&) const /Users/sftnight/ROOT-CI/src/math/minuit2/src/AnalyticalGradientCalculator.cxx:26
2024-06-27T16:52:12.5387860Z [/Users/sftnight/ROOT-CI/build/lib/libMinuit2.so] ROOT::Minuit2::VariableMetricBuilder::Minimum(ROOT::Minuit2::MnFcn const&, ROOT::Minuit2::GradientCalculator const&, ROOT::Minuit2::MinimumSeed const&, std::__1::vector<ROOT::Minuit2::MinimumState, std::__1::allocator<ROOT::Minuit2::MinimumState>>&, unsigned int, double) const /Users/sftnight/ROOT-CI/src/math/minuit2/src/VariableMetricBuilder.cxx:303
2024-06-27T16:52:12.5390290Z [/Users/sftnight/ROOT-CI/build/lib/libMinuit2.so] ROOT::Minuit2::VariableMetricBuilder::Minimum(ROOT::Minuit2::MnFcn const&, ROOT::Minuit2::GradientCalculator const&, ROOT::Minuit2::MinimumSeed const&, ROOT::Minuit2::MnStrategy const&, unsigned int, double) const /Users/sftnight/ROOT-CI/src/math/minuit2/src/VariableMetricBuilder.cxx:116
2024-06-27T16:52:12.5392570Z [/Users/sftnight/ROOT-CI/build/lib/libMinuit2.so] ROOT::Minuit2::ModularFunctionMinimizer::Minimize(ROOT::Minuit2::MnFcn const&, ROOT::Minuit2::GradientCalculator const&, ROOT::Minuit2::MinimumSeed const&, ROOT::Minuit2::MnStrategy const&, unsigned int, double) const /Users/sftnight/ROOT-CI/src/math/minuit2/src/ModularFunctionMinimizer.cxx:0
2024-06-27T16:52:12.5406250Z [/Users/sftnight/ROOT-CI/build/lib/libMinuit2.so] ROOT::Minuit2::ModularFunctionMinimizer::Minimize(ROOT::Minuit2::FCNGradientBase const&, ROOT::Minuit2::MnUserParameterState const&, ROOT::Minuit2::MnStrategy const&, unsigned int, double) const /Users/sftnight/ROOT-CI/src/math/minuit2/src/ModularFunctionMinimizer.cxx:194
2024-06-27T16:52:12.5410150Z [/Users/sftnight/ROOT-CI/build/lib/libMinuit2.so] ROOT::Minuit2::Minuit2Minimizer::Minimize() /Users/sftnight/ROOT-CI/src/math/minuit2/src/Minuit2Minimizer.cxx:557
2024-06-27T16:52:12.5413060Z [/Users/sftnight/ROOT-CI/build/lib/libMathCore.so] ROOT::Fit::Fitter::DoMinimization(ROOT::Math::IBaseFunctionMultiDimTempl<double> const*) /Users/sftnight/ROOT-CI/src/math/mathcore/src/Fitter.cxx:800
2024-06-27T16:52:12.5416020Z [/Users/sftnight/ROOT-CI/build/lib/libRooFitCore.so] RooMinimizer::minimize(char const*, char const*) /Users/sftnight/ROOT-CI/src/roofit/roofitcore/src/RooMinimizer.cxx:332
2024-06-27T16:52:12.5419110Z [/Users/sftnight/ROOT-CI/build/lib/libRooFitCore.so] RooFit::FitHelpers::minimize(RooAbsReal&, RooAbsReal&, RooAbsData const&, RooCmdConfig const&) /Users/sftnight/ROOT-CI/src/roofit/roofitcore/src/FitHelpers.cxx:555
2024-06-27T16:52:12.5422400Z [/Users/sftnight/ROOT-CI/build/lib/libRooFitCore.so] RooFit::FitHelpers::fitTo(RooAbsReal&, RooAbsData&, RooLinkedList const&, bool) /Users/sftnight/ROOT-CI/src/roofit/roofitcore/src/FitHelpers.cxx:1059
2024-06-27T16:52:12.5427050Z [/Users/sftnight/ROOT-CI/build/roofit/histfactory/test/testHistFactory] RooFitResult* RooAbsPdf::fitTo<RooFit::EvalBackend, RooCmdArg, RooCmdArg, RooCmdArg, RooCmdArg>(RooAbsData&, RooFit::EvalBackend const&, RooCmdArg const&, RooCmdArg const&, RooCmdArg const&, RooCmdArg const&) /Users/sftnight/ROOT-CI/src/roofit/roofitcore/inc/RooAbsPdf.h:159
2024-06-27T16:52:12.5431460Z [/Users/sftnight/ROOT-CI/build/roofit/histfactory/test/testHistFactory] HFFixtureFit_Fit_Test::TestBody() /Users/sftnight/ROOT-CI/src/roofit/histfactory/test/testHistFactory.cxx:680
2024-06-27T16:52:12.5434820Z [/Users/sftnight/ROOT-CI/build/roofit/histfactory/test/testHistFactory] void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (no debug info)
2024-06-27T16:52:12.5437660Z [/Users/sftnight/ROOT-CI/build/roofit/histfactory/test/testHistFactory] testing::Test::Run() (no debug info)
2024-06-27T16:52:12.5439550Z [/Users/sftnight/ROOT-CI/build/roofit/histfactory/test/testHistFactory] testing::TestInfo::Run() (no debug info)
2024-06-27T16:52:12.5441460Z [/Users/sftnight/ROOT-CI/build/roofit/histfactory/test/testHistFactory] testing::TestSuite::Run() (no debug info)
2024-06-27T16:52:12.5443560Z [/Users/sftnight/ROOT-CI/build/roofit/histfactory/test/testHistFactory] testing::internal::UnitTestImpl::RunAllTests() (no debug info)
2024-06-27T16:52:12.5446970Z [/Users/sftnight/ROOT-CI/build/roofit/histfactory/test/testHistFactory] bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (no debug info)
2024-06-27T16:52:12.5450080Z [/Users/sftnight/ROOT-CI/build/roofit/histfactory/test/testHistFactory] testing::UnitTest::Run() (no debug info)
2024-06-27T16:52:12.5451810Z [/Users/sftnight/ROOT-CI/build/roofit/histfactory/test/testHistFactory] main (no debug info)

guitargeek avatar Jul 08 '24 13:07 guitargeek

Reopened the PR with the "clean build" flag. This should hopefully fix the test failures on macOS.

I had this Idea because by chance I saw the same test failures on my own Arch Linux desktop when I did an incremental build where I updated the clad tag from 1.5 to master in between. It seems the re-build of clad didn't get triggered, which might have also happened on the CI.

guitargeek avatar Jul 08 '24 21:07 guitargeek

Are these changes not working with clad v1.5?

vgvassilev avatar Jul 09 '24 07:07 vgvassilev

Are these changes not working with clad v1.5?

Some of them. I have created a new PR that factors out the changes that work with v1.5, so that we can already merge these developments.

guitargeek avatar Jul 09 '24 14:07 guitargeek