root icon indicating copy to clipboard operation
root copied to clipboard

[meta] TClass: prefer typeid=>TClass map values with less Double32_t v2

Open dpiparo opened this issue 1 year ago • 1 comments

Reformulation of https://github.com/root-project/root/pull/12480


Both Foo and Foo<Double32_t> have the same typeid. Before this commit, TClass::GetClass(typeid(Foo)) would return whatever was registered last. This is not "stable"; it depends on which branch is accessed first, or which TClass::GetClass call happens first, or which library is loaded first.

Make this more reporducible by consistently preferring types will less Double32_t / Float16_t occurrences uin the typename.

While at this, only remove a TClass from the typeid=>TClass map if it really is the value for the typename.


This PR fixes #12509

dpiparo avatar May 22 '24 09:05 dpiparo

Test Results

    18 files      18 suites   4d 4h 9m 17s ⏱️  2 699 tests  2 691 ✅ 1 💤 7 ❌ 46 128 runs  46 121 ✅ 0 💤 7 ❌

For more details on these failures, see this check.

Results for commit 31d6e774.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 22 '24 09:05 github-actions[bot]

Thanks @pcanal for having another look.

dpiparo avatar Oct 31 '24 07:10 dpiparo