root icon indicating copy to clipboard operation
root copied to clipboard

Revert "[TO REVERT] Never run TMVA GNN tests and tutorials as unit tests"

Open guitargeek opened this issue 1 year ago • 4 comments

This reverts commit baf092324e6e2a9301daff36a780cd064b232c2d.

We can either merge this as-is if the tests pass, or if they don't I'll close this PR without merging and open a GitHub issue about fixing these tests.

guitargeek avatar May 22 '24 01:05 guitargeek

Test Results

    12 files      12 suites   2d 13h 5m 30s :stopwatch:  2 642 tests  2 642 :white_check_mark: 0 :zzz: 0 :x: 29 977 runs  29 977 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 4055d38e.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 22 '24 03:05 github-actions[bot]

I am a bit worried about seeing the CI fully green on this PR but at the same time the sonnet module was not even the right one to check for as highlighted by https://github.com/root-project/root/pull/15605

vepadulano avatar May 22 '24 13:05 vepadulano

Yes, the results of this PR are not valid. We'll have to see again tomorrow when the correct sonnet versions makes it into the CI images. In fact, one can see in the CI logs that the GNN tests didn't run.

guitargeek avatar May 22 '24 13:05 guitargeek

It worked! Here the relevant output from alma9:

Test   #62: pyunittests-pyroot-pyz-sofie-gnn ....................................   Passed   16.85 sec
Test  #556: tutorial-tmva-TMVA_SOFIE_GNN_Parser .................................   Passed   27.96 sec
Test #1092: tutorial-tmva-TMVA_SOFIE_GNN_Application ............................   Passed   16.76 sec
Test #1410: tutorial-tmva-TMVA_SOFIE_GNN-py .....................................   Passed   26.54 sec

From my side this is ready to go. The more robust Python requirement configuration is something to follow up on in another PR, this one was just to revert the protection against red builds if the added Python packages would enable tests that don't work.

guitargeek avatar May 23 '24 15:05 guitargeek