root icon indicating copy to clipboard operation
root copied to clipboard

[ntuple] Manually read RNTuple fields in Streamer()

Open silverweed opened this issue 1 year ago • 1 comments

...instead of relying on ReadClassBuffer(). This is necessary for schema evolution with RNTuple's custom streamer.

Changes or fixes:

Using TBuffer::ReadClassBuffer in RNTuple::Streamer is wrong because it doesn't handle cases where the schema of RNTuple changes. To do that, we need to manually read back the fields depending on the class version.

Checklist:

  • [x] tested changes locally
  • [ ] updated the docs (if necessary) - not necessary

silverweed avatar May 15 '24 07:05 silverweed

Test Results

    10 files      10 suites   1d 23h 7m 51s :stopwatch:  2 635 tests  2 635 :white_check_mark: 0 :zzz: 0 :x: 24 868 runs  24 868 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 1de11d83.

github-actions[bot] avatar May 15 '24 09:05 github-actions[bot]