root icon indicating copy to clipboard operation
root copied to clipboard

[RF] Fix behaviour of getAllConstraints

Open will-cern opened this issue 1 year ago • 2 comments

In trying to debug the fit to the CMS higgs discovery workspace, I found that the way the constraintTerm is determined will be buggy if doing a stripDisconnected determination of the constraint terms (i.e. not using the Constrain option). The cause is that the RooArgSet of parameters passed to RooAbsPdf::getConstraints gets modified, and therefore subsequent components don't see the full list of parameters of the parent pdf, so the list of constraint terms ends up being incomplete.

I think this PR fixes things

will-cern avatar May 07 '24 17:05 will-cern

Test Results

    10 files      10 suites   1d 20h 39m 25s :stopwatch:  2 635 tests  2 634 :white_check_mark: 0 :zzz: 1 :x: 24 868 runs  24 867 :white_check_mark: 0 :zzz: 1 :x:

For more details on these failures, see this check.

Results for commit c5793bae.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 08 '24 02:05 github-actions[bot]

Ok I think this should now be ready to go. This issue explains why the Constrain(np) was otherwise needed to get the cms higgs fits to work. Now I think that option should become unnecessary (will test fully once merged into master)

will-cern avatar May 08 '24 12:05 will-cern