root icon indicating copy to clipboard operation
root copied to clipboard

TEnum::GetEnum normalize name before search.

Open pcanal opened this issue 1 year ago • 5 comments

This allows to resolved using statement and find the target enum.

This fixes #15406 and is tested by https://github.com/root-project/roottest/pull/1118

This also fixes: https://github.com/root-project/root/issues/12685

pcanal avatar May 02 '24 21:05 pcanal

Test Results

    10 files      10 suites   1d 20h 14m 17s :stopwatch:  2 634 tests  2 634 :white_check_mark: 0 :zzz: 0 :x: 24 842 runs  24 842 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 5fe5a823.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 02 '24 23:05 github-actions[bot]

This LGTM (also in view of https://github.com/root-project/roottest/pull/1118, thanks for the test!), but is now marked as a Draft - what does this mean?

hahnjo avatar May 06 '24 15:05 hahnjo

It went to draft after I saw test failure that were tracked down to the missing write lock when changing the autoloading state. This has now been corrected.

pcanal avatar May 06 '24 19:05 pcanal

This also fixes https://github.com/root-project/root/issues/12685

pcanal avatar May 06 '24 21:05 pcanal

This fixes the run of roottest.root.meta.enums.execTEnumGetEnum on Windows (the roottest PR removes the will fail)

The failure on Windows was due to typeinfo(enum_type) returning a name with the format enum enumname and until the addition (in this PR) of the name normalization step, this was incorrectly handled by TEnum::GetEnum

pcanal avatar May 06 '24 21:05 pcanal

The backport to v6-32-00-patches failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v6-32-00-patches v6-32-00-patches
# Navigate to the new working tree
cd .worktrees/backport-v6-32-00-patches
# Create a new branch
git switch --create backport-15408-to-v6-32-00-patches
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6219b6baba5d7e9602ba1790ee540c5fc0e2db0d
# Push it to GitHub
git push --set-upstream origin backport-15408-to-v6-32-00-patches
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v6-32-00-patches

Then, create a pull request where the base branch is v6-32-00-patches and the compare/head branch is backport-15408-to-v6-32-00-patches.

github-actions[bot] avatar May 08 '24 06:05 github-actions[bot]