root icon indicating copy to clipboard operation
root copied to clipboard

[RF] ExternalConstraints documentation incorrect for RooMCStudy

Open goi42 opened this issue 1 year ago • 0 comments

Explain what you would like to see improved and how.

The documentation for the RooMCStudy constructor says for the argument ExternalConstraints: "Apply internal constraints on given parameters in fit and sample constrained parameter values from constraint p.d.f for each toy." This is not correct. Looking at the source code, it appears that the ExternalConstraints are simply added to the fit options that are eventually passed internally to fitTo.

It would be better, I think, to simply eliminate this as an argument to RooMCStudy. It should instead just be allowed as part of the arbitrary FitOptions. This would be more transparent.

ROOT version

v6.32

Installation method

N/A

Operating system

N/A

Additional context

No response

goi42 avatar May 02 '24 16:05 goi42