root icon indicating copy to clipboard operation
root copied to clipboard

[PyROOT] Sync with upstream cppyy

Open guitargeek opened this issue 1 year ago • 1 comments

Closes #15104.

Thank you very much @wlav for helping out here!

Needs to be backported to 6.32.

guitargeek avatar Apr 05 '24 11:04 guitargeek

Test Results

    13 files      13 suites   3d 1h 20m 45s :stopwatch:  3 025 tests  3 025 :white_check_mark: 0 :zzz: 0 :x: 33 786 runs  33 786 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 6c5f5deb.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 05 '24 13:04 github-actions[bot]

Do we keep track of which commit/point-of-development this correspond to in the cppyy repository?

pcanal avatar Aug 08 '24 17:08 pcanal

No, we don't, but that's a good idea.

Next time we touch the code, we will update the syncing script to use a specific commit from the upstream repositories: https://github.com/root-project/root/blob/master/bindings/pyroot/cppyy/sync-upstream

guitargeek avatar Aug 09 '24 12:08 guitargeek

The script seems to be using 'https://github.com/guitargeek/CPyCppyy.git', would it make sense to use a repository within the root-project umbrella?

pcanal avatar Aug 09 '24 14:08 pcanal

We want to avoid rebasing branches from forks altogether, and just use patches only. So once my PR to CPyCppyy is merged, these lines can be removed from the sync script.

It's my fault that it didn't get merged yet. I still have to implement a unit test :)

guitargeek avatar Aug 09 '24 17:08 guitargeek