root icon indicating copy to clipboard operation
root copied to clipboard

[TMath] Add moving mean, moving median and mode

Open pitkajuh opened this issue 1 year ago • 5 comments

This Pull request:

Changes or fixes:

Dear all. This pull request adds moving mean, moving median and mode to Root's TMath. I tried to update the documentation (https://root.cern/doc/v630/namespaceTMath.html) but I could not figure out where to find the files on Github. Please can someone guide me?

I will leave the PR in draft state. I will appreciate any feedback you can give me.

Checklist:

  • [X] tested changes locally
  • [X] updated the docs (if necessary)

This PR fixes #14258 LastTest.log.tar.gz

pitkajuh avatar Mar 30 '24 16:03 pitkajuh

Can one of the admins verify this patch?

phsft-bot avatar Mar 30 '24 16:03 phsft-bot

Test Results

     8 files       8 suites   1d 16h 13m 42s :stopwatch:  2 573 tests  2 573 :white_check_mark: 0 :zzz: 0 :x: 19 933 runs  19 933 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 2c241ef7.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 01 '24 11:04 github-actions[bot]

Thanks for your PR ! The documentation is automatically generated based on the comments on top of the function implementation. No need to modify anything extra. You have to follow the Doxygen format. So please use things like the \param \return keywords.

      /**
       * a normal member taking two arguments and returning an integer value.
       * \param a an integer argument.
       * \param s a constant character pointer.
       * \see Javadoc_Test()
       * \return The test results
       */

ferdymercury avatar Apr 02 '24 10:04 ferdymercury

Dear All. I edited the according to suggestions and added descriptions for the functions. If there is anything you want me to change, please let me know.

pitkajuh avatar Apr 13 '24 07:04 pitkajuh

FYI, some of the suggestions given for #15100 are also applicable in this PR. I will make changes accordingly.

pitkajuh avatar May 10 '24 15:05 pitkajuh