root icon indicating copy to clipboard operation
root copied to clipboard

[RF] Don't support `proof` anymore in RooFit and RooStats

Open guitargeek opened this issue 1 year ago • 10 comments

The PROOF interface in RooFit/RooStats didn't work anymore for a long time, so nobody will be suprised if this is removed.

guitargeek avatar Mar 16 '24 18:03 guitargeek

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Mar 16 '24 19:03 phsft-bot

Build failed on windows10/default. See console output.

phsft-bot avatar Mar 16 '24 19:03 phsft-bot

Test Results

    18 files      18 suites   3d 23h 6m 28s ⏱️  2 664 tests  2 664 ✅ 0 💤 0 ❌ 46 234 runs  46 234 ✅ 0 💤 0 ❌

Results for commit 240b6105.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Mar 16 '24 21:03 github-actions[bot]

Great simplification, which matches well the PROOF=OFF by default in master: thanks. This is not very important, but could users rely on some other sort of parallelism, e.g. T{Thread/Process}Executor?

dpiparo avatar Mar 17 '24 06:03 dpiparo

Thanks! Related: maybe it's good to remove also TProof and other deprecated features from the roofit tutorials. Right now, many are failing while building the docu, see: https://lcgapp-services.cern.ch/root-jenkins/view/ROOT/job/root-makedoc-master/lastBuild/console

things like:

warning: 'createIterator' is deprecated: will be removed in ROOT v6.34: begin(), end() and range-based for loops. 
use of undeclared identifier 'TProofLite' because of inc/RooStats/ProofConfig.h:            int nMaxWorkers = gROOT->ProcessLineFast("TProofLite::GetNumberOfWorkers()");
Warning in <ROOT::Math::Fitter::CalculateHessErrors>: Error when calculating Hessian
 *** Break *** segmentation violation

ferdymercury avatar Mar 18 '24 19:03 ferdymercury

Hi @ferdymercury, that's what I did in this PR. Or was there something I missed?

guitargeek avatar Mar 19 '24 15:03 guitargeek

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Mar 19 '24 15:03 phsft-bot

Oh right, sorry! I think the only thing missing would be to replace the deprecated createIterator functions in two or three files under tutorials. grep -r createIterator tutorials/

ferdymercury avatar Mar 19 '24 16:03 ferdymercury

Build failed on windows10/default. Running on null:C:\build\workspace\root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Mar 19 '24 17:03 phsft-bot

Oh right, sorry! I think the only thing missing would be to replace the deprecated createIterator functions in two or three files under tutorials. grep -r createIterator tutorials/

Thanks I get it now! I have opened a PR, feel free to review if you have time: https://github.com/root-project/root/pull/15024

guitargeek avatar Mar 20 '24 13:03 guitargeek