root-project
[core] Introduce suffix in `TSystem::TempFileName()` method
Allows to specify extension of temporary-created file.
Used in webgui to create temporary html files to start web widgets
Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds
Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.tmva.pymva.test.PyMVA_Torch_Classification
- projectroot.tmva.pymva.test.PyMVA_Torch_Regression
- projectroot.tmva.pymva.test.PyMVA_Torch_Multiclass
- projectroot.tmva.pymva.test.gtest_tmva_pymva_test_TestRModelParserPyTorch
Build failed on windows10/default. Running on null:C:\build\workspace\root-pullrequests-build See console output.
Failing tests:
- projectroot.roottest.root.meta.MakeProject.roottest_root_meta_MakeProject_stl_makeproject_test_build
- projectroot.roottest.root.meta.MakeProject.roottest_root_meta_MakeProject_examples
- projectroot.roottest.root.meta.MakeProject.roottest_root_meta_MakeProject_stltest
- projectroot.roottest.root.meta.MakeProject.roottest_root_meta_MakeProject_stltest2
Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.tmva.pymva.test.PyMVA_Torch_Classification
- projectroot.tmva.pymva.test.PyMVA_Torch_Regression
- projectroot.tmva.pymva.test.PyMVA_Torch_Multiclass
- projectroot.tmva.pymva.test.gtest_tmva_pymva_test_TestRModelParserPyTorch
Build failed on ROOT-performance-centos8-multicore/soversion. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.
Failing tests:
Test Results
11 files 11 suites 2d 5h 44m 33s :stopwatch: 2 564 tests 2 563 :white_check_mark: 0 :zzz: 1 :x: 26 384 runs 26 382 :white_check_mark: 0 :zzz: 2 :x:
For more details on these failures, see this check.
Results for commit e75e3725.
:recycle: This comment has been updated with latest results.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds
Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.roottest.python.numba.roottest_python_numba_numba
- projectroot.tmva.pymva.test.PyMVA_Torch_Classification
- projectroot.tmva.pymva.test.PyMVA_Torch_Regression
- projectroot.tmva.pymva.test.PyMVA_Torch_Multiclass
- projectroot.tmva.pymva.test.gtest_tmva_pymva_test_TestRModelParserPyTorch
Build failed on ROOT-performance-centos8-multicore/soversion. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.
Failing tests:
Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.tmva.pymva.test.PyMVA_Torch_Regression
- projectroot.tmva.pymva.test.PyMVA_Torch_Classification
- projectroot.tmva.pymva.test.PyMVA_Torch_Multiclass
- projectroot.tmva.pymva.test.gtest_tmva_pymva_test_TestRModelParserPyTorch
Looks good to me except the question on the Windows implementation of TempFileName.
Probably rename not needed at all. File not yet exists. One can just will create new file with new name.
Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds
Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds
Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.tmva.pymva.test.PyMVA_Torch_Regression
- projectroot.tmva.pymva.test.PyMVA_Torch_Multiclass
- projectroot.tmva.pymva.test.PyMVA_Torch_Classification
- projectroot.tmva.pymva.test.gtest_tmva_pymva_test_TestRModelParserPyTorch
Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.tmva.pymva.test.PyMVA_Torch_Regression
- projectroot.tmva.pymva.test.PyMVA_Torch_Classification
- projectroot.tmva.pymva.test.PyMVA_Torch_Multiclass
- projectroot.tmva.pymva.test.gtest_tmva_pymva_test_TestRModelParserPyTorch
Build failed on ROOT-performance-centos8-multicore/soversion. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.
Failing tests:
@bellenot
Does this branch works at all on Windows? I mean - starting any web widgets like browser or canvas?
Does this branch works at all on Windows? I mean - starting any web widgets like browser or canvas?
I don't know, I didn't try it. I will try and let you know (but it will take some time...)
@linev it works. it created a temporary html file as C:\Users\bellenot\AppData\Local\Temp\rooA90E.tmp.html
it works. it created a temporary html file as C:\Users\bellenot\AppData\Local\Temp\rooA90E.tmp.html
Grate. Do we want more changes in Windows code? Can you approve PR?