root
root copied to clipboard
root-project
[math][fit] Change FitFCN/SetFCN to pass a flag for the type of fit
In the FitFCN/SetFCN functions use a flag for the fit type instead of passing a boolean for the chi2 fit. The flag is by default 0 (undefined type), but can be 1 (for chi2 fit), so compatible as passing a boolean as before, 2 for unbinned likelihood and 3 for binned likelihood (FCN is defined to be the Baker-Cousins log-likelihood ratio)
By passing the correct flag the function FitResult::Chi2() returns the corresponding Chi2() and the Baker-Cousins chi2 equivalent in case a binned likelihood fits.
This PR fixes #11143
Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds
Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.tmva.pymva.test.PyMVA_Torch_Classification
- projectroot.tmva.pymva.test.PyMVA_Torch_Regression
- projectroot.tmva.pymva.test.PyMVA_Torch_Multiclass
- projectroot.tmva.pymva.test.gtest_tmva_pymva_test_TestRModelParserPyTorch
Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.tmva.pymva.test.PyMVA_Torch_Classification
- projectroot.tmva.pymva.test.PyMVA_Torch_Regression
- projectroot.tmva.pymva.test.PyMVA_Torch_Multiclass
- projectroot.tmva.pymva.test.gtest_tmva_pymva_test_TestRModelParserPyTorch
Build failed on ROOT-performance-centos8-multicore/soversion. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.
Failing tests:
Test Results
12 files 12 suites 2d 2h 5m 28s :stopwatch: 2 562 tests 2 561 :white_check_mark: 0 :zzz: 1 :x: 28 822 runs 28 821 :white_check_mark: 0 :zzz: 1 :x:
For more details on these failures, see this check.
Results for commit c6f32083.
:recycle: This comment has been updated with latest results.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds
Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.tmva.pymva.test.PyMVA_Torch_Classification
- projectroot.tmva.pymva.test.PyMVA_Torch_Regression
- projectroot.tmva.pymva.test.PyMVA_Torch_Multiclass
- projectroot.tmva.pymva.test.gtest_tmva_pymva_test_TestRModelParserPyTorch
Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
- projectroot.tmva.pymva.test.PyMVA_Torch_Classification
- projectroot.tmva.pymva.test.PyMVA_Torch_Regression
- projectroot.tmva.pymva.test.PyMVA_Torch_Multiclass
- projectroot.tmva.pymva.test.gtest_tmva_pymva_test_TestRModelParserPyTorch
Build failed on ROOT-performance-centos8-multicore/soversion. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.