root icon indicating copy to clipboard operation
root copied to clipboard

[cling] use one instead of two lookups within TClass::Init()

Open ferdymercury opened this issue 1 year ago • 15 comments

This Pull request:

Changes or fixes:

Fixes https://github.com/root-project/root/issues/7123

Checklist:

  • [x] tested changes locally
  • [x] updated the docs (if necessary)

ferdymercury avatar Feb 19 '24 11:02 ferdymercury

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 19 '24 11:02 phsft-bot

Getting some errors at the moment, like:

Error in <TInterpreter::InspectMembers>: Cannot find Decl for class TEnum is not a CXXRecordDecl.
Error in <TInterpreter::InspectMembers>: Cannot find Decl for class TProtoClass is not a CXXRecordDecl.
Error in <TInterpreter::InspectMembers>: Cannot find Decl for class TEnum is not a CXXRecordDecl.

ferdymercury avatar Feb 19 '24 11:02 ferdymercury

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

phsft-bot avatar Feb 19 '24 12:02 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2024-02-19T13:36:33.562Z] FAILED: tmva/sofie/test/CMakeFiles/SofieCompileModels_ROOT.util

phsft-bot avatar Feb 19 '24 13:02 phsft-bot

Build failed on ROOT-performance-centos8-multicore/soversion. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

phsft-bot avatar Feb 19 '24 14:02 phsft-bot

Build failed on mac12arm/cxx20. Running on 194.12.161.128:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

phsft-bot avatar Feb 19 '24 14:02 phsft-bot

Test Results

    11 files     11 suites   4d 11h 3m 49s :stopwatch:  2 567 tests   835 :white_check_mark: 0 :zzz:  1 732 :x: 26 402 runs  8 983 :white_check_mark: 0 :zzz: 17 419 :x:

For more details on these failures, see this check.

Results for commit 35e6a609.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 19 '24 18:02 github-actions[bot]

The errors seems related to the changes. (i.e they are unexpected).

pcanal avatar Feb 19 '24 21:02 pcanal

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 21 '24 18:02 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2024-02-21T18:55:24.151Z] FAILED: tmva/sofie/test/CMakeFiles/SofieCompileModels_ROOT.util

phsft-bot avatar Feb 21 '24 18:02 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

phsft-bot avatar Feb 21 '24 19:02 phsft-bot

Build failed on windows10/default. Running on null:C:\build\workspace\root-pullrequests-build See console output.

phsft-bot avatar Feb 21 '24 19:02 phsft-bot

Build failed on mac12arm/cxx20. Running on 194.12.161.128:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

phsft-bot avatar Feb 21 '24 19:02 phsft-bot

Build failed on ROOT-performance-centos8-multicore/soversion. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

phsft-bot avatar Feb 21 '24 20:02 phsft-bot

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 23 '24 12:02 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

phsft-bot avatar Feb 23 '24 12:02 phsft-bot

Build failed on ROOT-performance-centos8-multicore/soversion. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

phsft-bot avatar Feb 23 '24 13:02 phsft-bot

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 23 '24 14:02 phsft-bot

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 23 '24 14:02 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

phsft-bot avatar Feb 23 '24 14:02 phsft-bot

Build failed on ROOT-performance-centos8-multicore/soversion. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

phsft-bot avatar Feb 23 '24 15:02 phsft-bot

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 23 '24 16:02 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2024-02-23T16:08:35.323Z] /home/sftnight/build/workspace/root-pullrequests-build/root/core/metacling/src/TCling.cxx:4050:52: error: ‘TDictionary::DeclId_t’ {aka ‘const void*’} is not a pointer-to-object type

phsft-bot avatar Feb 23 '24 16:02 phsft-bot

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 23 '24 16:02 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

phsft-bot avatar Feb 23 '24 16:02 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2024-02-23T18:09:57.597Z] FAILED: tmva/sofie/test/CMakeFiles/SofieCompileModels_ROOT.util

phsft-bot avatar Feb 23 '24 18:02 phsft-bot

Build failed on ROOT-performance-centos8-multicore/soversion. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

phsft-bot avatar Feb 23 '24 19:02 phsft-bot