root icon indicating copy to clipboard operation
root copied to clipboard

Add integrator multi dim tutorial

Open atolosadelgado opened this issue 1 year ago • 8 comments

Fixes https://github.com/root-project/root/issues/7740

This Pull request:

Changes or fixes:

Add tutorial about multi dimensional integrator

Checklist:

  • [x ] tested changes locally
  • [ ] updated the docs (if necessary)

This PR fixes # https://github.com/root-project/root/issues/7740

atolosadelgado avatar Feb 14 '24 15:02 atolosadelgado

Can one of the admins verify this patch?

phsft-bot avatar Feb 14 '24 15:02 phsft-bot

@phsft-bot build

hahnjo avatar Feb 14 '24 18:02 hahnjo

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 14 '24 18:02 phsft-bot

Build failed on ROOT-ubuntu2004/python3. See console output.

phsft-bot avatar Feb 14 '24 18:02 phsft-bot

Test Results

    10 files      10 suites   2d 0h 57m 58s :stopwatch:  2 543 tests  2 539 :white_check_mark: 0 :zzz: 4 :x: 23 942 runs  23 936 :white_check_mark: 0 :zzz: 6 :x:

For more details on these failures, see this check.

Results for commit cddda247.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 15 '24 14:02 github-actions[bot]

@atolosadelgado : we are 1 typo away from merging the PR and closing the issue. Do you have a moment to address the minimal comment which was made?

dpiparo avatar Feb 16 '24 07:02 dpiparo

Hi,

I fixed the typo in the new tutorial, and in the older tutorial from which I copypasted the header :)

atolosadelgado avatar Feb 16 '24 11:02 atolosadelgado

triggered building and testing. If everything goes well, for me the PR is ready to be merged!

dpiparo avatar Feb 16 '24 12:02 dpiparo

@phsft-bot build

vepadulano avatar Feb 23 '24 09:02 vepadulano

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 23 '24 09:02 phsft-bot

Build failed on ROOT-performance-centos8-multicore/soversion. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Feb 23 '24 10:02 phsft-bot

@phsft-bot build

vepadulano avatar Feb 26 '24 09:02 vepadulano

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 26 '24 09:02 phsft-bot

@vepadulano this PR doesn't have Philippe's fix and therefore blocks the mac12 and mac13 nodes (until I notice and manually cancel the jobs). If this needs more CI runs, please consider rebasing on latest master to avoid that...

hahnjo avatar Feb 26 '24 10:02 hahnjo

@vepadulano this PR doesn't have Philippe's fix and therefore blocks the mac12 and mac13 nodes (until I notice and manually cancel the jobs). If this needs more CI runs, please consider rebasing on latest master to avoid that...

Thank you for noticing. I have just sync the branch, I hope now the tests pass.

atolosadelgado avatar Feb 26 '24 14:02 atolosadelgado