root icon indicating copy to clipboard operation
root copied to clipboard

Published 20 hours ago • verified publisher icon root-project

[ntuple] minimal support for unsplit fields

Open jblomer opened this issue 1 year ago • 71 comments

Introduces a new RFieldBase descendant, RUnsplitField. This field uses an offset column and an std::byte column to store ROOT I/O streamed objects. To create unsplit fields one can

  • directly add an RUnsplitField to the model or
  • set the rntuple.split=false class attribute (TClass API or selection XML input to genreflex).

Note that the unsplit comment (//||) is ignored for the time being.

The "rntuple.split=true" attribute can be used to use RNTuple standard I/O on classes that have CanSplit() = false. E.g. for classes with a custom streamer that does not impact RNTuple I/O.

Adds a new field structure type, "unsplit", in the on-disk format.

The streaming needs more work, e.g. to store the streamer information. We can also consider using a different comment marker.

jblomer avatar Feb 14 '24 15:02 jblomer

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 14 '24 15:02 phsft-bot

Build failed on ROOT-ubuntu2004/python3. See console output.

phsft-bot avatar Feb 14 '24 15:02 phsft-bot

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 14 '24 15:02 phsft-bot

Build failed on ROOT-ubuntu2004/python3. See console output.

phsft-bot avatar Feb 14 '24 15:02 phsft-bot

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 14 '24 15:02 phsft-bot

Test Results

    10 files      10 suites   1d 20h 15m 23s :stopwatch:  2 633 tests  2 632 :white_check_mark: 0 :zzz: 1 :x: 24 822 runs  24 820 :white_check_mark: 0 :zzz: 2 :x:

For more details on these failures, see this check.

Results for commit bf32858e.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 15 '24 12:02 github-actions[bot]

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 17 '24 12:02 phsft-bot

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 17 '24 12:02 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2024-02-17T12:19:28.592Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RField.hxx:805:40: error: only virtual member functions can be marked 'final'

Warnings:

  • [2024-02-17T12:19:28.592Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RField.hxx:781:7: warning: abstract class is marked 'final' [-Wabstract-final-class]

phsft-bot avatar Feb 17 '24 12:02 phsft-bot

Build failed on ROOT-performance-centos8-multicore/soversion. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Errors:

  • [2024-02-17T12:50:16.883Z] /data/sftnight/workspace/root-pullrequests-build/build/include/ROOT/RField.hxx:805:40: error: only virtual member functions can be marked 'final'

Warnings:

  • [2024-02-17T12:50:16.883Z] /data/sftnight/workspace/root-pullrequests-build/build/include/ROOT/RField.hxx:781:7: warning: abstract class is marked 'final' [-Wabstract-final-class]

phsft-bot avatar Feb 17 '24 12:02 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2024-02-17T12:53:53.065Z] FAILED: tree/ntuple/G__ROOTNTuple.cxx lib/ROOTNTuple.pcm
  • [2024-02-17T12:53:53.992Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RField.hxx:805:40: error: only virtual member functions can be marked 'final'

Warnings:

  • [2024-02-17T12:53:53.992Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RField.hxx:781:7: warning: abstract class is marked 'final' [-Wabstract-final-class]

phsft-bot avatar Feb 17 '24 12:02 phsft-bot

Build failed on mac12arm/cxx20. Running on 194.12.161.128:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2024-02-17T13:08:56.329Z] FAILED: tree/ntuple/G__ROOTNTuple.cxx lib/ROOTNTuple.pcm /Users/sftnight/build/workspace/root-pullrequests-build/build/tree/ntuple/G__ROOTNTuple.cxx /Users/sftnight/build/workspace/root-pullrequests-build/build/lib/ROOTNTuple.pcm
  • [2024-02-17T13:08:57.125Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RField.hxx:805:40: error: only virtual member functions can be marked 'final'

Warnings:

  • [2024-02-17T13:08:57.125Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RField.hxx:781:7: warning: abstract class is marked 'final' [-Wabstract-final-class]

phsft-bot avatar Feb 17 '24 13:02 phsft-bot

Build failed on windows10/default. Running on null:C:\build\workspace\root-pullrequests-build See console output.

phsft-bot avatar Feb 17 '24 13:02 phsft-bot

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 19 '24 14:02 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2024-02-19T14:18:17.327Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RField.hxx:808:40: error: only virtual member functions can be marked 'final'

Warnings:

  • [2024-02-19T14:18:17.327Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RField.hxx:784:7: warning: abstract class is marked 'final' [-Wabstract-final-class]

phsft-bot avatar Feb 19 '24 14:02 phsft-bot

Build failed on windows10/default. Running on null:C:\build\workspace\root-pullrequests-build See console output.

phsft-bot avatar Feb 19 '24 15:02 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2024-02-19T15:47:54.535Z] FAILED: tree/ntuple/G__ROOTNTuple.cxx lib/ROOTNTuple.pcm
  • [2024-02-19T15:47:55.508Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RField.hxx:808:40: error: only virtual member functions can be marked 'final'

Warnings:

  • [2024-02-19T15:47:55.508Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RField.hxx:784:7: warning: abstract class is marked 'final' [-Wabstract-final-class]

phsft-bot avatar Feb 19 '24 15:02 phsft-bot

Build failed on ROOT-performance-centos8-multicore/soversion. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Errors:

  • [2024-02-19T17:40:09.962Z] /data/sftnight/workspace/root-pullrequests-build/build/include/ROOT/RField.hxx:808:40: error: only virtual member functions can be marked 'final'

Warnings:

  • [2024-02-19T17:40:09.962Z] /data/sftnight/workspace/root-pullrequests-build/build/include/ROOT/RField.hxx:784:7: warning: abstract class is marked 'final' [-Wabstract-final-class]

phsft-bot avatar Feb 19 '24 17:02 phsft-bot

Build failed on mac12arm/cxx20. Running on 194.12.161.128:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2024-02-19T17:41:59.868Z] FAILED: tree/ntuple/G__ROOTNTuple.cxx lib/ROOTNTuple.pcm /Users/sftnight/build/workspace/root-pullrequests-build/build/tree/ntuple/G__ROOTNTuple.cxx /Users/sftnight/build/workspace/root-pullrequests-build/build/lib/ROOTNTuple.pcm
  • [2024-02-19T17:42:00.802Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RField.hxx:808:40: error: only virtual member functions can be marked 'final'

Warnings:

  • [2024-02-19T17:42:00.802Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RField.hxx:784:7: warning: abstract class is marked 'final' [-Wabstract-final-class]

phsft-bot avatar Feb 19 '24 17:02 phsft-bot

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 21 '24 23:02 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Feb 21 '24 23:02 phsft-bot

Build failed on windows10/default. Running on null:C:\build\workspace\root-pullrequests-build See console output.

phsft-bot avatar Feb 22 '24 00:02 phsft-bot

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 22 '24 09:02 phsft-bot

Build failed on windows10/default. Running on null:C:\build\workspace\root-pullrequests-build See console output.

phsft-bot avatar Feb 22 '24 10:02 phsft-bot

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Mar 01 '24 13:03 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Mar 01 '24 14:03 phsft-bot

Build failed on windows10/default. Running on null:C:\build\workspace\root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Mar 01 '24 15:03 phsft-bot

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Mar 07 '24 09:03 phsft-bot

Build failed on windows10/default. See console output.

phsft-bot avatar Mar 07 '24 10:03 phsft-bot

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Mar 07 '24 10:03 phsft-bot