root icon indicating copy to clipboard operation
root copied to clipboard

[WIP][FreeBSD] fix davix build

Open mkrzewic opened this issue 1 year ago • 2 comments

This Pull request:

is a proposal.

  • fixes the use of sed - the in place option requires a suffix argument as opposed to gnu sed where this is optional
  • explicitly calls gmake for davix. This may or may not be the thing to do - the problem is cmake calls "make -j --" which again relies on a gnu make behaviour where the -j option does not require and argument. BSD make does. so either somehow a number needs to be supplied there or gmake gets called explicitly like in this PR.

This PR fixes # #14697

mkrzewic avatar Feb 14 '24 13:02 mkrzewic

Can one of the admins verify this patch?

phsft-bot avatar Feb 14 '24 13:02 phsft-bot

Test Results

    12 files      12 suites   2d 22h 40m 30s :stopwatch:  3 021 tests  3 015 :white_check_mark: 0 :zzz:  6 :x: 31 190 runs  31 180 :white_check_mark: 0 :zzz: 10 :x:

For more details on these failures, see this check.

Results for commit a250c7a1.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 15 '24 10:02 github-actions[bot]

@phsft-bot build

hahnjo avatar Feb 23 '24 07:02 hahnjo

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 23 '24 07:02 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

phsft-bot avatar Feb 23 '24 07:02 phsft-bot

Build failed on ROOT-performance-centos8-multicore/soversion. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

phsft-bot avatar Feb 23 '24 08:02 phsft-bot

Build failed on mac12arm/cxx20. Running on 194.12.161.128:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Feb 23 '24 09:02 phsft-bot