root icon indicating copy to clipboard operation
root copied to clipboard

[hist] Add SaveAs method to TH1

Open dpnrlz opened this issue 1 year ago • 13 comments

This Pull request:

Changes or fixes:

Add SaveAs method to TH1, saving to .csv, .tsv or .txt

Checklist:

  • [x] tested changes locally
  • [x] updated the docs (if necessary)

This PR fixes #10474

dpnrlz avatar Feb 14 '24 10:02 dpnrlz

Can one of the admins verify this patch?

phsft-bot avatar Feb 14 '24 10:02 phsft-bot

@phsft-bot build

hahnjo avatar Feb 14 '24 10:02 hahnjo

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 14 '24 10:02 phsft-bot

Build failed on ROOT-ubuntu2004/python3. See console output.

phsft-bot avatar Feb 14 '24 10:02 phsft-bot

@phsft-bot build

hahnjo avatar Feb 14 '24 11:02 hahnjo

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 14 '24 11:02 phsft-bot

Build failed on ROOT-ubuntu2004/python3. See console output.

phsft-bot avatar Feb 14 '24 11:02 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Feb 14 '24 12:02 phsft-bot

@phsft-bot build

lmoneta avatar Feb 14 '24 13:02 lmoneta

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 14 '24 13:02 phsft-bot

Build failed on ROOT-ubuntu2004/python3. See console output.

phsft-bot avatar Feb 14 '24 13:02 phsft-bot

Build failed on windows10/default. Running on null:C:\build\workspace\root-pullrequests-build See console output.

Errors:

  • [2024-02-14T14:42:05.921Z] C:\Program Files (x86)\Windows Kits\10\Include\10.0.19041.0\ucrt\corecrt_wstring.h(20,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\lib\Serialization\ASTWriterStmt.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm-project\llvm\tools\clang\lib\Serialization\obj.clangSerialization.vcxproj]
  • [2024-02-14T14:42:05.921Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\llvm\include\llvm/Support/Casting.h(108,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\lib\AST\Interp\InterpBlock.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm-project\llvm\tools\clang\lib\AST\obj.clangAST.vcxproj]
  • [2024-02-14T14:42:05.921Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\llvm\include\llvm/Support/Casting.h(158,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\lib\AST\Interp\ByteCodeExprGen.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm-project\llvm\tools\clang\lib\AST\obj.clangAST.vcxproj]
  • [2024-02-14T14:42:06.656Z] C:\Program Files (x86)\Windows Kits\10\Include\10.0.19041.0\ucrt\stdio.h(1880,5): fatal error C1088: Cannot flush compiler intermediate file: 'C:\Users\sftnight\AppData\Local\Temp_CL_a5329a21ex': Invalid argument (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\lib\Driver\ToolChains\DragonFly.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm-project\llvm\tools\clang\lib\Driver\obj.clangDriver.vcxproj]
  • [2024-02-14T14:42:06.656Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\include\clang/AST/TemplateName.h(111,28): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\lib\AST\Interp\InterpState.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm-project\llvm\tools\clang\lib\AST\obj.clangAST.vcxproj]
  • [2024-02-14T14:42:06.656Z] C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.32.31326\include\array(15,9): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\lib\Driver\ToolChains\CSKYToolChain.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm-project\llvm\tools\clang\lib\Driver\obj.clangDriver.vcxproj]
  • [2024-02-14T14:42:06.656Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\llvm\include\llvm/Support/Casting.h(131,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\lib\AST\Interp\Function.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm-project\llvm\tools\clang\lib\AST\obj.clangAST.vcxproj]
  • [2024-02-14T14:42:07.284Z] C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.32.31326\include\chrono(380,73): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\lib\Driver\ToolChains\AMDGPU.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm-project\llvm\tools\clang\lib\Driver\obj.clangDriver.vcxproj]
  • [2024-02-14T14:42:07.284Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\include\clang/AST/Stmt.h(2619,25): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\lib\AST\Interp\InterpFrame.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm-project\llvm\tools\clang\lib\AST\obj.clangAST.vcxproj]
  • [2024-02-14T14:42:07.284Z] C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\llvm\include\llvm/ADT/SmallVector.h(648,1): fatal error C1060: compiler is out of heap space (compiling source file C:\build\workspace\root-pullrequests-build\root\interpreter\llvm-project\clang\lib\Driver\ToolChains\AMDGPUOpenMP.cpp) [C:\build\workspace\root-pullrequests-build\build\interpreter\llvm-project\llvm\tools\clang\lib\Driver\obj.clangDriver.vcxproj]

And 49 more

phsft-bot avatar Feb 14 '24 14:02 phsft-bot

Test Results

    12 files      12 suites   2d 5h 0m 31s :stopwatch:  2 568 tests  2 568 :white_check_mark: 0 :zzz: 0 :x: 28 870 runs  28 870 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 92fc8186.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 14 '24 15:02 github-actions[bot]

@phsft-bot build

vepadulano avatar Feb 26 '24 16:02 vepadulano

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 26 '24 16:02 phsft-bot

Dear Vincenzo,

That's great, thank you for all your help!

Cheers, Daniel

On Tue, 27 Feb 2024 at 13:21, Vincenzo Eduardo Padulano < @.***> wrote:

Merged #14713 https://github.com/root-project/root/pull/14713 into master.

— Reply to this email directly, view it on GitHub https://github.com/root-project/root/pull/14713#event-11934071904, or unsubscribe https://github.com/notifications/unsubscribe-auth/APZZFPHYZAW2ZKTEERUFCI3YVWXTXAVCNFSM6AAAAABDIBYBJSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRHEZTIMBXGE4TANA . You are receiving this because you were mentioned.Message ID: @.***>

dpnrlz avatar Feb 27 '24 10:02 dpnrlz