root icon indicating copy to clipboard operation
root copied to clipboard

[tgraph] Add TGraph::SetOption

Open rshrj opened this issue 1 year ago • 15 comments

To enable setting default draw option before drawing a graph like TH1::SetOption

Fixes https://github.com/root-project/root/issues/14539

This Pull request:

Changes or fixes:

Checklist:

  • [ ] tested changes locally
  • [ ] updated the docs (if necessary)

This PR fixes #

rshrj avatar Feb 13 '24 14:02 rshrj

Can one of the admins verify this patch?

phsft-bot avatar Feb 13 '24 14:02 phsft-bot

@phsft-bot build

hahnjo avatar Feb 13 '24 15:02 hahnjo

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 13 '24 15:02 phsft-bot

@phsft-bot build

hahnjo avatar Feb 13 '24 15:02 hahnjo

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 13 '24 15:02 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Feb 13 '24 17:02 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Feb 13 '24 17:02 phsft-bot

Build failed on windows10/default. Running on null:C:\build\workspace\root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Feb 13 '24 18:02 phsft-bot

Test Results

    10 files      10 suites   2d 4h 46m 34s :stopwatch:  2 568 tests  2 561 :white_check_mark: 0 :zzz: 7 :x: 24 257 runs  24 250 :white_check_mark: 0 :zzz: 7 :x:

For more details on these failures, see this check.

Results for commit 3b6200ab.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 14 '24 07:02 github-actions[bot]

@phsft-bot build

vepadulano avatar Feb 15 '24 12:02 vepadulano

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 15 '24 12:02 phsft-bot

Build failed on ROOT-ubuntu2004/python3. See console output.

phsft-bot avatar Feb 15 '24 12:02 phsft-bot

@lmoneta can you check again now and approve if everything looks good?

vepadulano avatar Feb 21 '24 16:02 vepadulano

@phsft-bot build

vepadulano avatar Feb 27 '24 14:02 vepadulano

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 27 '24 14:02 phsft-bot