root icon indicating copy to clipboard operation
root copied to clipboard

A shortcut to perform Modified and Update

Open couet opened this issue 1 year ago • 5 comments

Short cut to call Modified() and Update() in a single call. On Mac with Cocoa, it performs an additional ProcessEvents().

couet avatar Feb 13 '24 10:02 couet

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default How to customize builds

phsft-bot avatar Feb 13 '24 10:02 phsft-bot

Test Results

    12 files      12 suites   2d 14h 32m 0s :stopwatch:  2 559 tests  2 550 :white_check_mark: 0 :zzz:  9 :x: 28 788 runs  28 778 :white_check_mark: 0 :zzz: 10 :x:

For more details on these failures, see this check.

Results for commit 0e6b31ec.

github-actions[bot] avatar Feb 13 '24 19:02 github-actions[bot]

Just for my own understanding, how does this fix the linked issue? The user is responsible for calling ModifiedUpdated() instead of just Update or Modified? This means they have to change their code, so we would need documentation and a tutorial for that. Let me know if I misunderstood perhaps

vepadulano avatar Feb 15 '24 12:02 vepadulano

On Mac, an extra "ProcessEvent" is needed to flush the buffers. It can not be included in Update() (many long discussions with Timur about that. I do not remember the details but that was the conclusion). As very often Update() goes with Modified(), the idea was to group them and on Mac perform the extra ProcessEvent. That's the best we can do to allow the user code to be the same on different machines.

couet avatar Feb 20 '24 08:02 couet

Right, so this means this PR is adding a new method that allows to address the cases such as the one reported by the linked issue, but it's not a drop-in replacement, the user needs to actively know that the new method exists and use it. All clear now, thanks for the explanation.

vepadulano avatar Feb 21 '24 16:02 vepadulano

This PR was approved, are the test failures related? Otherwise I believe we could merge and close the issue? @linev @couet

vepadulano avatar Feb 27 '24 14:02 vepadulano

Hi @couet, @linev , gentle ping, can this PR be merged ?

vepadulano avatar Mar 04 '24 14:03 vepadulano

Yes sure.

couet avatar Mar 04 '24 16:03 couet